Closed Bug 1513547 Opened 3 years ago Closed 3 years ago
autocopy leaves tons of Selection objects around until the next cycle collection
... and since Selections are around, that affects to performance of painting of selection on Linux.
remote: View your change here: remote: https://hg.mozilla.org/try/rev/62322f4f05b87281aec487620c62e4ccbd4fdc35 remote: remote: Follow the progress of your build on Treeherder: remote: https://treeherder.mozilla.org/#/jobs?repo=try&revision=62322f4f05b87281aec487620c62e4ccbd4fdc35
Comment on attachment 9030901 [details] [diff] [review] auto_copy_selections.diff Since this is similar issue as bug 1376936, perhaps you ehsan could review this? Trying to clean up stuff sooner using _LAST_RELEASE And Range objects shouldn't need to keep selection alive, it is selection which needs to keep range objects alive. (this way there isn't cycle selection->range->selection) The normal Selection objects stay alive, since nsFrameSelection has an array of RefPtr<Selection> objects, but https://searchfox.org/mozilla-central/rev/3160ddc1f0ab55d230c595366662c62950e5c785/dom/base/nsCopySupport.cpp#310 and https://searchfox.org/mozilla-central/rev/adcc169dcf58c2e45ba65c4ed5661d666fc3ac74/dom/base/nsDocumentEncoder.cpp#1195 create temporary Selections.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/f20886290ab0 ensure selection objects created for autocopy are cleared as soon as possible, r=ehsan
You need to log in before you can comment on or make changes to this bug.