1513599 - Fix/enable ESLint 'react/destructuring-assignment'

Status: NEW

(Tree Management :: Treeherder: Frontend, enhancement, P3)

Description

[Ed Morley [:emorley]]

https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/destructuring-assignment.md

Comment 1

[Ed Morley [:emorley]]

Example failure shown by `yarn lint` after removing the rule-disabling from .eslintrc.js:

error: Must use destructuring props assignment (react/destructuring-assignment) at ui\job-view\pushes\PushHeader.jsx:35:16:
  33 |   return (
  34 |     <span title="View pushes by this user" className="push-author">
> 35 |       <a href={props.url}>{authorEmail}</a>
     |                ^
  36 |     </span>
  37 |   );
  38 | }

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/5105

Comment 3

[Cameron Dawson [:camd]]

I won't get to this anytime soon.