1513605 - configuration with clang fails on aarch64 linux

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Guillaume GARDET]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36

Steps to reproduce:

Try to build aarch64 linux with clang 6.0.1


Actual results:

Got this result error message:
[  454s]  2:24.10 mozbuild.frontend.reader.BuildReaderError:
[  454s]  2:24.10 ==============================
[  454s]  2:24.10 FATAL ERROR PROCESSING MOZBUILD FILE
[  454s]  2:24.10 ==============================
[  454s]  2:24.10 The error occurred while processing the following file:
[  454s]  2:24.10     /home/abuild/rpmbuild/BUILD/firefox-64.0/mozglue/misc/moz.build
[  454s]  2:24.10 A moz.build file called the error() function.
[  454s]  2:24.10 The error it encountered is:
[  454s]  2:24.10     No TimeStamp implementation on this platform.  Build will not succeed
[  454s]  2:24.10 Correct the error condition and try again.
[  455s]  2:24.39 *** Fix above errors and then restart with\
[  455s]  2:24.39                "./mach build"
[  455s]  2:24.39 gmake: *** [client.mk:115: configure] Error 1

It seems to be due to:
[  395s]  1:24.33 checking for clock_gettime(CLOCK_MONOTONIC)... no
[  395s]  1:24.60 checking for pthread_cond_timedwait_monotonic_np...


Expected results:

Building with clang should succeed as it does with GCC.

Comment 1

[Mike Hommey [:glandium]]

> [  395s]  1:24.33 checking for clock_gettime(CLOCK_MONOTONIC)... no

What kind of Linux system are you using that doesn't have CLOCK_MONOTONIC?

Comment 2

[Guillaume GARDET]

(In reply to Mike Hommey [:glandium] from comment #1)
> > [  395s]  1:24.33 checking for clock_gettime(CLOCK_MONOTONIC)... no
> 
> What kind of Linux system are you using that doesn't have CLOCK_MONOTONIC?

It is an openSUSE system. The problem is CLOCK_MONOTONIC is supported. So, I do not understand why the test fails.

Comment 3

[Mike Hommey [:glandium]]

Check config.log.

Comment 4

[Guillaume GARDET]

(In reply to Mike Hommey [:glandium] from comment #3)
> Check config.log.

According to config.log, this is due to:
  /usr/bin/ld: /tmp/conftest-f21630.o(.text.main+0xc): unresolvable R_AARCH64_ADR_PREL_PG_HI21 relocation against symbol `__stack_chk_guard@@GLIBC_2.17'
  /usr/bin/ld: final link failed: nonrepresentable section on output
  clang-6.0.1: error: linker command failed with exit code 1 (use -v to see invocation)

Adding '-fPIC' to LD flags seems to make the config to pass.

Comment 5

[Mike Hommey [:glandium]]

Interestingly, I've hit this problem on, not aarch64, but armhf and armel, with gold. Can you try to add:

ac_add_options --enable-linker=bfd

to your mozconfig?

Comment 6

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #5)
> Interestingly, I've hit this problem

Well, not _exactly_ this problem, but a similar one.

Comment 7

[Guillaume GARDET]

(In reply to Mike Hommey [:glandium] from comment #5)
> Interestingly, I've hit this problem on, not aarch64, but armhf and armel,
> with gold. Can you try to add:
> 
> ac_add_options --enable-linker=bfd
> 
> to your mozconfig?

Adding 'ac_add_options --enable-linker=bfd' does not help in my case.

But as mentionned in Comment#4, adding '-fPIC' helps.

Comment 8

[Mike Hommey [:glandium]]

Attachment: Bug 1513605 - Add PIC flags when running the clock_gettime(CLOCK_MONOTONIC) check.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f6582e6dba4b
Add PIC flags when running the clock_gettime(CLOCK_MONOTONIC) check. r=dmajor

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/f6582e6dba4b