Remove source-map module from debugger server

RESOLVED FIXED in Firefox 66

Status

enhancement
P2
normal
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: loganfsmyth, Assigned: loganfsmyth)

Tracking

(Blocks 1 bug)

Trunk
Firefox 66
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

We currently have two separate implementations of source-map. One was used with the old debugger and was part of the server, and the newer one is part of the HTML debugger system and is used by all current devtools.

We should remove the old one as it complicated the debugger server and is unused.
Priority: -- → P2
Depends on: 1514248
Attachment #9030850 - Attachment description: Bug 1513655 - Part 2: Remove source-map module and usage from the debugger server. r=jlast → Bug 1513655 - Remove source-map module and usage from the debugger server. r=jlast
Attachment #9030849 - Attachment is obsolete: true
Pushed by lsmyth@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4d61e1b695c9
Remove source-map module and usage from the debugger server. r=jlast
See also bug 1364992.  According to that, there are some other things related
to this that can be removed as well.  I don't know whether that bug is still
accurate though.
Blocks: source-maps
Backed out for ESlint failure on devtools/server/actors/thread.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&fromchange=4d61e1b695c9d74477270dcd8bd692d2faf5d4c8&tochange=b40c8b4f9cae7ed33a7383d0f5dbc883608b6531&selectedJob=217078360

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=217078360&repo=autoland&lineNumber=285

Backout link: https://hg.mozilla.org/integration/autoland/rev/b40c8b4f9cae7ed33a7383d0f5dbc883608b6531

[task 2018-12-14T19:21:11.034Z] x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security build/temp.linux-x86_64-2.7/psutil/_psutil_common.o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o -o build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so
[task 2018-12-14T19:21:11.034Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_linux.so -> psutil
[task 2018-12-14T19:21:11.034Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so -> psutil
[task 2018-12-14T19:21:11.034Z] 
[task 2018-12-14T19:21:11.034Z] Error processing command. Ignoring because optional. (optional:packages.txt:comm/build/virtualenv_packages.txt)
[task 2018-12-14T19:26:12.169Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/server/actors/thread.js:1997:9 | 'sourceActor' is not defined. (no-undef)
[taskcluster 2018-12-14 19:26:12.714Z] === Task Finished ===
[taskcluster 2018-12-14 19:26:12.714Z] Unsuccessful task run with exit code: 1 completed in 622.861 seconds
Flags: needinfo?(lsmyth)
Pushed by lsmyth@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b1a9da82d2be
Remove source-map module and usage from the debugger server. r=jlast
Flags: needinfo?(lsmyth)
Blocks: 1512437
https://hg.mozilla.org/mozilla-central/rev/b1a9da82d2be
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in before you can comment on or make changes to this bug.