1513655 - Remove source-map module from debugger server

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P2)

Description

[Logan Smyth [:loganfsmyth]]

We currently have two separate implementations of source-map. One was used with the old debugger and was part of the server, and the newer one is part of the HTML debugger system and is used by all current devtools.

We should remove the old one as it complicated the debugger server and is unused.

Comment 1

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1513655 - Part 1: Use a new-source event for internal xpcshell tests. r=jlast

Comment 2

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1513655 - Remove source-map module and usage from the debugger server. r=jlast

Depends on D14295

Comment 3

[Logan Smyth [:loganfsmyth]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6c76c0a92f93e6d6c3181bf88710740c2f3a02a7

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d61e1b695c9
Remove source-map module and usage from the debugger server. r=jlast

Comment 5

[Tom Tromey :tromey]

See also bug 1364992.  According to that, there are some other things related
to this that can be removed as well.  I don't know whether that bug is still
accurate though.

Comment 6

[Cosmin Sabou [:CosminS]]

Backed out for ESlint failure on devtools/server/actors/thread.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&fromchange=4d61e1b695c9d74477270dcd8bd692d2faf5d4c8&tochange=b40c8b4f9cae7ed33a7383d0f5dbc883608b6531&selectedJob=217078360

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=217078360&repo=autoland&lineNumber=285

Backout link: https://hg.mozilla.org/integration/autoland/rev/b40c8b4f9cae7ed33a7383d0f5dbc883608b6531

[task 2018-12-14T19:21:11.034Z] x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security build/temp.linux-x86_64-2.7/psutil/_psutil_common.o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o -o build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so
[task 2018-12-14T19:21:11.034Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_linux.so -> psutil
[task 2018-12-14T19:21:11.034Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so -> psutil
[task 2018-12-14T19:21:11.034Z] 
[task 2018-12-14T19:21:11.034Z] Error processing command. Ignoring because optional. (optional:packages.txt:comm/build/virtualenv_packages.txt)
[task 2018-12-14T19:26:12.169Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/server/actors/thread.js:1997:9 | 'sourceActor' is not defined. (no-undef)
[taskcluster 2018-12-14 19:26:12.714Z] === Task Finished ===
[taskcluster 2018-12-14 19:26:12.714Z] Unsuccessful task run with exit code: 1 completed in 622.861 seconds

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1a9da82d2be
Remove source-map module and usage from the debugger server. r=jlast

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b1a9da82d2be