1513671 - [wpt-sync] Sync PR 14481 - [LayoutNG] Exclude trailing preserved spaces when avoiding floats

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 14481 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14481
Details from upstream follow.

Koji Ishii <[e-mail]> wrote:
>  [LayoutNG] Exclude trailing preserved spaces when avoiding floats
>  
>  This patch fixes an interoperability issue where trailing
>  preserved spaces should be excluded when avoiding floats.
>  All 4 implementations are interoperable on this regard.
>  
>  This patch adds NGLineInfo::HasOverflow(), because knowing
>  whether the line has overflow or not is easy and fast,
>  while knowing the exact inline size excluding trailing
>  preserved spaces may involve reshaping.
>  
>  Other cases also have interoperability problems, such as
>  `text-align` or `min-content`. I'll investigate them in
>  following patches.
>  
>  Bug: 913995
>  Change-Id: Ibf13f1fcc28bbd99d44b56611141efa49d6d1c89
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1374329
>  WPT-Export-Revision: b97a8c9d9ab17309aa23528935417a6286806276

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=b0c9d858c99b399f8276fef83d4af1a688a1ecf9

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=c78300b48eb93c587ff0a3774c145d75ca72b748

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=06b06ec3d177b1f91b552e1c3c2ba8560b941f3b

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=45f5e85c6e5649d27ab1770d6536fd5ea65a56ba

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Ran 2 tests
PASS   : 2

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/12dad58d97d7
[wpt PR 14481] - [LayoutNG] Exclude trailing preserved spaces when avoiding floats, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/97b7940ad337
[wpt PR 14481] - Update wpt metadata, a=testonly

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/12dad58d97d7
https://hg.mozilla.org/mozilla-central/rev/97b7940ad337