[wpt-sync] Sync PR 14481 - [LayoutNG] Exclude trailing preserved spaces when avoiding floats

RESOLVED FIXED in Firefox 66

Status

()

enhancement
P4
normal
RESOLVED FIXED
5 months ago
4 months ago

People

(Reporter: wptsync, Unassigned)

Tracking

unspecified
mozilla66
Points:
---

Firefox Tracking Flags

(firefox66 fixed)

Details

(Whiteboard: [wptsync downstream], )

Assignee

Description

5 months ago
Sync web-platform-tests PR 14481 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14481
Details from upstream follow.

Koji Ishii <kojii@chromium.org> wrote:
>  [LayoutNG] Exclude trailing preserved spaces when avoiding floats
>  
>  This patch fixes an interoperability issue where trailing
>  preserved spaces should be excluded when avoiding floats.
>  All 4 implementations are interoperable on this regard.
>  
>  This patch adds NGLineInfo::HasOverflow(), because knowing
>  whether the line has overflow or not is easy and fast,
>  while knowing the exact inline size excluding trailing
>  preserved spaces may involve reshaping.
>  
>  Other cases also have interoperability problems, such as
>  `text-align` or `min-content`. I'll investigate them in
>  following patches.
>  
>  Bug: 913995
>  Change-Id: Ibf13f1fcc28bbd99d44b56611141efa49d6d1c89
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1374329
>  WPT-Export-Revision: b97a8c9d9ab17309aa23528935417a6286806276
Assignee

Updated

5 months ago
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Assignee

Updated

5 months ago
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Assignee

Updated

5 months ago
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Assignee

Comment 5

5 months ago
Ran 2 tests
PASS   : 2

Comment 6

4 months ago
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/12dad58d97d7
[wpt PR 14481] - [LayoutNG] Exclude trailing preserved spaces when avoiding floats, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/97b7940ad337
[wpt PR 14481] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.