Closed Bug 1513882 Opened 11 months ago Closed 10 months ago
To AMO install button does not show the puzzle piece in the awesome bar
STR: In Firefox 66, `browser.newtabpage.activity-stream.asrouter.devtoolsEnabled` set to true. 1. Navigate to `about:newtab#asrouter` 2. Scroll to the bottom and click the `Force Attribution` button 3. Naviate to `about:welcome`. You should the the RTAMO message with information about installing an addon. 4. Proceed with the installation and the step in the screenshot will appear.
The addons logo should show up next to the magnifing glass.
Iteration: --- → 66.2 - Dec 24 - Jan 6
Priority: -- → P2
Summary: about:welcome RTMO install button does not show the puzzle piece in the awesome bar → about:welcome ReturnToAMO install button does not show the puzzle piece in the awesome bar
This isn't ideal and should be fixed at some point, but I think we have a number of strange behaviors with doorhanger positions on new tab and probably needs a comprehensive fix. That being said, I don't really see this as blocking.
Hi Andrei, Can you please add steps to replicate this issue. Thanks!
User Story: (updated)
On debugging, issue seems to be pageproxystate is invalid for urlbar element on about:welcome page and we hide notification-popup-box box containing addons-notification icon by default for invalid states https://searchfox.org/mozilla-central/source/browser/base/content/browser.css#754 One option to fix is explicitly unhiding notification-popup-box before sending AddonManager.getInstallForUrl call from about:welcome page https://searchfox.org/mozilla-central/source/browser/components/newtab/lib/ASRouter.jsm#226 Other option is to update pageproxystate to 'valid' for about:welcome provided location bar on welcome page doesn't have any dependent feature tied to invalid pageproxystate
https://searchfox.org/mozilla-central/source/browser/base/content/browser.js#2789 The string "valid" indicates that the security indicators and other related user interface elments should be shown which we probably don't want for welcome page, will submit patch with fix in ASRouter.jsm to unhide addons-notification icon.
Iteration: 66.2 - Dec 24 - Jan 6 → 66.3 - Jan 7 - 20
You need to log in before you can comment on or make changes to this bug.