Closed
Bug 1513882
Opened 5 years ago
Closed 5 years ago
about:welcome ReturnToAMO install button does not show the puzzle piece in the awesome bar
Categories
(Firefox :: Messaging System, defect, P2)
Firefox
Messaging System
Tracking
()
People
(Reporter: andreio, Assigned: pdahiya)
References
Details
(Keywords: github-merged)
User Story
STR: In Firefox 66, `browser.newtabpage.activity-stream.asrouter.devtoolsEnabled` set to true. 1. Navigate to `about:newtab#asrouter` 2. Scroll to the bottom and click the `Force Attribution` button 3. Naviate to `about:welcome`. You should the the RTAMO message with information about installing an addon. 4. Proceed with the installation and the step in the screenshot will appear.
Attachments
(2 files)
Screen Shot 2018-12-13 at 14.20.25.png
The addons logo should show up next to the magnifing glass.
|
||
Updated•5 years ago
|
Iteration: --- → 66.2 - Dec 24 - Jan 6
status-firefox65:
--- → fix-optional
status-firefox66:
--- → affected
Keywords: uiwanted
Priority: -- → P2
Summary: about:welcome RTMO install button does not show the puzzle piece in the awesome bar → about:welcome ReturnToAMO install button does not show the puzzle piece in the awesome bar
|
||
Comment 1•5 years ago
|
||
This isn't ideal and should be fixed at some point, but I think we have a number of strange behaviors with doorhanger positions on new tab and probably needs a comprehensive fix. That being said, I don't really see this as blocking.
|
Assignee | |
Comment 2•5 years ago
|
||
Hi Andrei, Can you please add steps to replicate this issue. Thanks!
Flags: needinfo?(andrei.br92)
|
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → pdahiya
|
Reporter | |
Updated•5 years ago
|
User Story: (updated)
Flags: needinfo?(andrei.br92)
|
|
Assignee | |
Comment 3•5 years ago
|
||
On debugging, issue seems to be pageproxystate is invalid for urlbar element on about:welcome page and we hide notification-popup-box box containing addons-notification icon by default for invalid states https://searchfox.org/mozilla-central/source/browser/base/content/browser.css#754 One option to fix is explicitly unhiding notification-popup-box before sending AddonManager.getInstallForUrl call from about:welcome page https://searchfox.org/mozilla-central/source/browser/components/newtab/lib/ASRouter.jsm#226 Other option is to update pageproxystate to 'valid' for about:welcome provided location bar on welcome page doesn't have any dependent feature tied to invalid pageproxystate
|
|
Assignee | |
Comment 4•5 years ago
|
||
https://searchfox.org/mozilla-central/source/browser/base/content/browser.js#2789 The string "valid" indicates that the security indicators and other related user interface elments should be shown which we probably don't want for welcome page, will submit patch with fix in ASRouter.jsm to unhide addons-notification icon.
|
|
||
Updated•5 years ago
|
Iteration: 66.2 - Dec 24 - Jan 6 → 66.3 - Jan 7 - 20
|
|
Assignee | |
Comment 5•5 years ago
|
||
Pull Request in GitHub
|
|
Assignee | |
Updated•5 years ago
|
Whiteboard: [github-merged]
|
|
Assignee | |
Comment 6•5 years ago
|
||
|
||
Updated•5 years ago
|
Keywords: github-merged
Whiteboard: [github-merged]
|
|
||
Comment 7•5 years ago
|
||
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
|
||
Updated•5 years ago
|
|
||
Comment 8•5 years ago
|
||
Verified using Nightly 66.0a1 (20190120213632) on Windows 10 x64 bit and MacOS. The puzzle icon is shown when installing the attributed addon each time.
Status: RESOLVED → VERIFIED
|
|
||
Comment 9•5 years ago
|
||
|
|
||
Updated•5 years ago
|
Component: Activity Streams: Newtab → Messaging System
You need to log in
before you can comment on or make changes to this bug.
Description
•