Closed Bug 1513901 Opened 6 years ago Closed 6 years ago

Remove the virtual keyword from two functions on the ESR branch

Categories

(Core :: General, enhancement)

Product:
Core
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox-esr60 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

Bug 1513901 - Remove the virtual keyword from two fuctions on the ESR branch
47 bytes, text/x-phabricator-request
lizzard
: approval-mozilla-esr60+
Details | Review
This is in order to fix an orange Cvf job that will happen as a result of reformatting the ESR tree: <https://treeherder.mozilla.org/#/jobs?repo=try&revision=3e3bdd821e63965f342588c503399822f10c83b0&selectedJob=216748802>
Blocks: 1513900
Comment on attachment 9031121 [details] Bug 1513901 - Remove the virtual keyword from two fuctions on the ESR branch [ESR Uplift Approval Request] If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required in order to fix an orange job that results from pushing the reformat commit (based on a try push). User impact if declined: Orange jobs resulting from pushing the clang-format commit to esr60. Fix Landed on Version: Not landed yet Risk to taking this patch: Low Why is the change risky/not risky? (and alternatives if risky): Not risky, removing a couple of redundant keywords String or UUID changes made by this patch: None
Attachment #9031121 - Flags: approval-mozilla-esr60?
Comment on attachment 9031121 [details] Bug 1513901 - Remove the virtual keyword from two fuctions on the ESR branch OK for uplift to ESR for clang-format project.
Attachment #9031121 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: