Remove multiple subclasses of PIndexedDBPermissionRequestChild

RESOLVED FIXED in Firefox 68

Status

()

enhancement
P1
normal
RESOLVED FIXED
8 months ago
4 months ago

People

(Reporter: Alex_Gaynor, Assigned: Alex_Gaynor)

Tracking

(Blocks 1 bug)

Trunk
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66 wontfix, firefox67 wontfix, firefox68 fixed)

Details

Attachments

(3 attachments)

In bug 1512990 we're discussing devirtualizing the Recv/Send messages, which requires each protocol class to only have a single implementor.

In this case I think it's possible to just remove the entire interface and replace it with async-returns.
This removes the only case of an IPDL protocol which has two implementors,
which we need to fix in order to devirtualize all IPC Recv/Send calls.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8b0d99539339c48e6ed90bfc06629441d83ea1c2

Does indexeddb have enough test coverage that I should feel confident on the basis of these, or does it need manual testing/additional OSs?
Yeah, I think we have solid test coverage.
Great! So I guess this patch probably works at least a little :-)
Attachment #9031203 - Attachment description: Bug 1513911 - replace PIndexedDBPermissionRequest with async returns in IPC; r?janv → Bug 1513911 - Part 2 - replace PIndexedDBPermissionRequest with async returns in IPC; r?janv
Blocks: 1526019
No longer blocks: ipc-devirt

Hey Jan, do you think you'll have a chance to review this? Is there another reviewer who might have more bandwidth?

Flags: needinfo?(jvarga)
Attachment #9031203 - Attachment description: Bug 1513911 - Part 2 - replace PIndexedDBPermissionRequest with async returns in IPC; r?janv → Bug 1513911 - Part 3 - replace PIndexedDBPermissionRequest with async returns in IPC; r?janv

Hey, sorry it took so long, we are finishing a big project and I won't be available on Monday/Tuesday.
You can ask :asuth to take the review.

Flags: needinfo?(jvarga)

Thanks Jan!

Keywords: checkin-needed

Pushed by aiakab@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6d1442f6c07b
Part 1 - added a missing include; r=keeler
https://hg.mozilla.org/integration/autoland/rev/10e12617d3c5
Part 2 - fixed a missing include; r=mccr8

Keywords: checkin-needed

Part 3 needs rebasing.

Keywords: leave-open
Attachment #9031203 - Attachment description: Bug 1513911 - Part 3 - replace PIndexedDBPermissionRequest with async returns in IPC; r?janv → Bug 1513911 - Part 3 - replace PIndexedDBPermissionRequest with async returns in IPC; r?asuth

Only part 3 needs to be landed.

Pushed by rvandermeulen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/14daa74eecfb
Part 3 - replace PIndexedDBPermissionRequest with async returns in IPC; r=asuth

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.