1513911 - Remove multiple subclasses of PIndexedDBPermissionRequestChild

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, enhancement, P1)

Description

[Alex Gaynor [:Alex_Gaynor]]

In bug 1512990 we're discussing devirtualizing the Recv/Send messages, which requires each protocol class to only have a single implementor.

In this case I think it's possible to just remove the entire interface and replace it with async-returns.

Comment 1

[Alex Gaynor [:Alex_Gaynor]]

Attachment: Bug 1513911 - Part 3 - replace PIndexedDBPermissionRequest with async returns in IPC; r?asuth

This removes the only case of an IPDL protocol which has two implementors,
which we need to fix in order to devirtualize all IPC Recv/Send calls.

Comment 2

[Alex Gaynor [:Alex_Gaynor]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8b0d99539339c48e6ed90bfc06629441d83ea1c2

Does indexeddb have enough test coverage that I should feel confident on the basis of these, or does it need manual testing/additional OSs?

Comment 3

[Jan Varga [:janv]]

Yeah, I think we have solid test coverage.

Comment 4

[Alex Gaynor [:Alex_Gaynor]]

Great! So I guess this patch probably works at least a little :-)

Comment 5

[Alex Gaynor [:Alex_Gaynor]]

Attachment: Bug 1513911 - Part 1 - added a missing include; r?keeler

Comment 6

[Alex Gaynor [:Alex_Gaynor]]

Hey Jan, do you think you'll have a chance to review this? Is there another reviewer who might have more bandwidth?

Comment 7

[Alex Gaynor [:Alex_Gaynor]]

Attachment: Bug 1513911 - Part 2 - fixed a missing include; r?mccr8

Depends on D18995

Comment 8

[Jan Varga [:janv]]

Hey, sorry it took so long, we are finishing a big project and I won't be available on Monday/Tuesday.
You can ask :asuth to take the review.

Comment 9

[Alex Gaynor [:Alex_Gaynor]]

Thanks Jan!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d1442f6c07b
Part 1 - added a missing include; r=keeler
https://hg.mozilla.org/integration/autoland/rev/10e12617d3c5
Part 2 - fixed a missing include; r=mccr8

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Part 3 needs rebasing.

Comment 12

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/6d1442f6c07b
https://hg.mozilla.org/mozilla-central/rev/10e12617d3c5

Comment 13

[Alex Gaynor [:Alex_Gaynor]]

Only part 3 needs to be landed.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14daa74eecfb
Part 3 - replace PIndexedDBPermissionRequest with async returns in IPC; r=asuth

Comment 15

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/14daa74eecfb