1513912 - Crash in java.lang.NoSuchMethodError: at org.mozilla.gecko.SpeechSynthesisService$2.run(SpeechSynthesisService.java)

Status: VERIFIED FIXED

(Core :: Web Speech, defect, P1)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is
report bp-2fb786f1-eb98-4455-9005-d07cc0181212.
=============================================================

Seen while looking at crash stats: https://bit.ly/2PAzT0d. This particular crash seems higher on 64.0b15 than on 63.0.2 release. Seems to be API 16 (Jelly Bean only) crash.

There is another higher volume signature, https://bit.ly/2rIxyXX, which are non Jelly Bean crashes and APIs range from 28 down.

Some comments mention crashing while reading Yahoo news, but the URLs are quite varied.

Java stack trace:

java.lang.NoSuchMethodError
	at org.mozilla.gecko.SpeechSynthesisService$2.run(SpeechSynthesisService.java:56)
	at android.os.Handler.handleCallback(Handler.java:615)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:137)
	at org.mozilla.gecko.util.GeckoBackgroundThread.run(GeckoBackgroundThread.java:43)

Comment 1

[Ryan VanderMeulen [:RyanVM]]

ISTR another Fennec crash in the past involving speech which ended up being related to ads being served?

Comment 2

[Andrew Overholt [:overholt]]

Susheel, what should we do here?

Comment 3

[:sdaswani]

Seems like a gecko issue given the stack trace? Snorp or DB can you advise?

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

This might be Eitan's area.

Comment 5

[Eitan Isaacson [:eeejay]]

I think the NoSuchMethodError exception was resolved with bug 1510611.

As for the NullPointerException, I can post a patch here.

Comment 6

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1513912 - Null check return from TextToSpeech.getFeatures() r?agi!

Comment 7

[Ryan VanderMeulen [:RyanVM]]

I doubt we want to backport all of bug 1510611, but would it be worth extracting out the relevant bits for an uplift patch here?

Comment 8

[Eitan Isaacson [:eeejay]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #7)
> I doubt we want to backport all of bug 1510611, but would it be worth
> extracting out the relevant bits for an uplift patch here?

Sure.

Comment 9

[Eitan Isaacson [:eeejay]]

Attachment: Null check return from TextToSpeech.getFeatures() r?agi!

This will be the patch we should ultimately uplift to beta.

Comment 10

[James Willcox (:snorp) ([e-mail]) (he/him)]

Looks like Eitan has this under control.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f98a1c651b3
Null check return from TextToSpeech.getFeatures() r=agi

Comment 12

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/2f98a1c651b3

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

Can you request uplift to beta, and possibly to mozilla-release as well? 
Thanks!

Comment 14

[Liz Henry (:lizzard) (relman/hg->git project)]

We may want to consider this as a ride-along in case we have a 64 dot release.

Comment 15

[Eitan Isaacson [:eeejay]]

Comment on attachment 9032827 [details] [diff] [review]
Null check return from TextToSpeech.getFeatures() r?agi!

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: None

User impact if declined: Some crashing when web speech API is invoked.

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): It's been verified on nightly and it's pretty straightforward.

String changes made/needed:

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9032827 [details] [diff] [review]
Null check return from TextToSpeech.getFeatures() r?agi!

[Triage Comment]
Fixes some crashes with the Web Speech API. Approved for 65.0b7.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/22da6211feb6

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Crashes are gone in 65.0b7 \m/

Comment 19

[Julien Cristau [:jcristau]]

Comment on attachment 9032827 [details] [diff] [review]
Null check return from TextToSpeech.getFeatures() r?agi!

fix for #5 top crash for fennec 64.0.1, verified in 65b, approved for 64.0.2

Comment 20

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-release/rev/c58ea2229c33