47 bytes, text/x-phabricator-request
|Details | Review|
1.73 KB, patch
|Details | Diff | Splinter Review|
This bug was filed from the Socorro interface and is report bp-2fb786f1-eb98-4455-9005-d07cc0181212. ============================================================= Seen while looking at crash stats: https://bit.ly/2PAzT0d. This particular crash seems higher on 64.0b15 than on 63.0.2 release. Seems to be API 16 (Jelly Bean only) crash. There is another higher volume signature, https://bit.ly/2rIxyXX, which are non Jelly Bean crashes and APIs range from 28 down. Some comments mention crashing while reading Yahoo news, but the URLs are quite varied. Java stack trace: java.lang.NoSuchMethodError at org.mozilla.gecko.SpeechSynthesisService$2.run(SpeechSynthesisService.java:56) at android.os.Handler.handleCallback(Handler.java:615) at android.os.Handler.dispatchMessage(Handler.java:92) at android.os.Looper.loop(Looper.java:137) at org.mozilla.gecko.util.GeckoBackgroundThread.run(GeckoBackgroundThread.java:43)
Crash Signature: [@ java.lang.NoSuchMethodError: at org.mozilla.gecko.SpeechSynthesisService$2.run(SpeechSynthesisService.java)] → [@ java.lang.NoSuchMethodError: at org.mozilla.gecko.SpeechSynthesisService$2.run(SpeechSynthesisService.java)] [@ java.lang.NullPointerException: at org.mozilla.gecko.SpeechSynthesisService$2.run(SpeechSynthesisService.java) ]
ISTR another Fennec crash in the past involving speech which ended up being related to ads being served?
Susheel, what should we do here?
Seems like a gecko issue given the stack trace? Snorp or DB can you advise?
This might be Eitan's area.
Flags: needinfo?(dbolter) → needinfo?(eitan)
I think the NoSuchMethodError exception was resolved with bug 1510611. As for the NullPointerException, I can post a patch here.
I doubt we want to backport all of bug 1510611, but would it be worth extracting out the relevant bits for an uplift patch here?
Assignee: nobody → eitan
(In reply to Ryan VanderMeulen [:RyanVM] from comment #7) > I doubt we want to backport all of bug 1510611, but would it be worth > extracting out the relevant bits for an uplift patch here? Sure.
This will be the patch we should ultimately uplift to beta.
Looks like Eitan has this under control.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/2f98a1c651b3 Null check return from TextToSpeech.getFeatures() r=agi
Can you request uplift to beta, and possibly to mozilla-release as well? Thanks!
We may want to consider this as a ride-along in case we have a 64 dot release.
Comment on attachment 9032827 [details] [diff] [review] Null check return from TextToSpeech.getFeatures() r?agi! [Beta/Release Uplift Approval Request] Feature/Bug causing the regression: None User impact if declined: Some crashing when web speech API is invoked. Is this code covered by automated tests?: No Has the fix been verified in Nightly?: Yes Needs manual test from QE?: No If yes, steps to reproduce: List of other uplifts needed: None Risk to taking this patch: Low Why is the change risky/not risky? (and alternatives if risky): It's been verified on nightly and it's pretty straightforward. String changes made/needed:
Comment on attachment 9032827 [details] [diff] [review] Null check return from TextToSpeech.getFeatures() r?agi! [Triage Comment] Fixes some crashes with the Web Speech API. Approved for 65.0b7.
Attachment #9032827 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Crashes are gone in 65.0b7 \m/
You need to log in before you can comment on or make changes to this bug.