1514171 - Follow up Bug 1509383 - Fix the XCUITests affected by that bug

Status: RESOLVED FIXED

(Firefox for iOS :: Build & Test, enhancement)

Description

[Isabel Rios[:isabel_rios]]

With that new implementation: Bug 1509383 - WKURLSchemeHander for all except reader mode
Commit: https://github.com/mozilla-mobile/firefox-ios/commit/8b1450fbeb87f1f559a2f8e42971c715dc96bcaf

These are the following issues with the tests: 

- A new tab was named as "home" but now it is "home?#panel=0" is this a desired behaviour? If so, the fix is easy, the tests will be modified accordingly.
Example of failing test:
https://dashboard.buddybuild.com/apps/57bf25c0f096bc01001e21e0/build/5c130ea4b1d5d00001c39ae3/test/00ec1447-b2cb-4747-bfe5-88f7212cabb2/fdbfaf5e-4ee5-49a5-8a47-6eed729d7acd
This is affecting several tests.

- Find in page, large doc tests are failing because now the website is not correctly loaded, please see log here with screenshot9. 
https://dashboard.buddybuild.com/apps/57bf25c0f096bc01001e21e0/build/5c130ea4b1d5d00001c39ae3/test/00ec1447-b2cb-4747-bfe5-88f7212cabb2/c6022929-5aae-41fb-b8c6-359740f5e009

Since that website is  built here:
https://github.com/mozilla-mobile/firefox-ios/blob/master/XCUITests/WebPagesForTesting.swift

And called as: navigator.openURL("http://localhost:6571/find-in-page-test.html")
We will need to to some changes there...Just guessing I tried calling it as navigator.openURL("internal://local/find-in-page-test.html") but didn't work...
I would need your help to understand how to fix this issue. Thanks!

Comment 1

[Isabel Rios[:isabel_rios]]

Garvan, I'm sure you knew I was going to ping you after this patch ;)

Comment 2

[:garvan]

Yay for tests.

I am fixing these now.

Comment 3

[:garvan]

https://github.com/mozilla-mobile/firefox-ios/pull/4430