Closed
Bug 1514175
Opened 6 years ago
Closed 6 years ago
Remove macOS fallback styling for the bookmarking panel tag selector checkboxes
Categories
(Firefox :: Theme, enhancement, P3)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: ntim, Assigned: nevetia.vedant)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
Since -moz-appearance: checkbox; takes care of the styling, except for the min-width/height, we can remove the fallback styling.
Here's the code to remove:
- https://searchfox.org/mozilla-central/rev/fd32b3a6fa3eff1468311f6fcf32b45c117136df/browser/themes/osx/places/editBookmark.css#59,62,64-67
- toolkit/themes/osx/global/checkbox/cbox-check.gif can be removed as well
- https://searchfox.org/mozilla-central/rev/fd32b3a6fa3eff1468311f6fcf32b45c117136df/toolkit/themes/osx/global/jar.mn#49
You'll also need to replace https://searchfox.org/mozilla-central/source/accessible/tests/mochitest/treeview.css#2 with url("chrome://global/skin/icons/check.svg")
Updated•6 years ago
|
Priority: -- → P3
Reporter | ||
Updated•6 years ago
|
Assignee: nobody → nevetia.vedant
Reporter | ||
Comment 2•6 years ago
|
||
Assigned it to you, please let me know if you have any questions!
Hi Tim. I've made the necessary changes. Please let me know if anything else needs to be changed. Thanks!
Updated•6 years ago
|
Attachment #9033532 -
Attachment description: Bug 1514175 Remove macOS fallback styling for the bookmarking panel tag selector checkboxes → Bug 1514175 - Remove macOS fallback styling for the bookmarking panel tag selector checkboxes
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/53ebd07fd26e
Remove macOS fallback styling for the bookmarking panel tag selector checkboxes r=dao
Comment 6•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in
before you can comment on or make changes to this bug.
Description
•