Closed Bug 1514175 Opened 5 years ago Closed 5 years ago

Remove macOS fallback styling for the bookmarking panel tag selector checkboxes

Categories

(Firefox :: Theme, enhancement, P3)

Product:
Firefox
Component:
Theme
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 66
Tracking Flags:
Tracking Status
firefox66 --- fixed

People

(Reporter: ntim, Assigned: nevetia.vedant)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Bug 1514175 - Remove macOS fallback styling for the bookmarking panel tag selector checkboxes
47 bytes, text/x-phabricator-request
Details | Review 
Since -moz-appearance: checkbox; takes care of the styling, except for the min-width/height, we can remove the fallback styling.

Here's the code to remove:
- https://searchfox.org/mozilla-central/rev/fd32b3a6fa3eff1468311f6fcf32b45c117136df/browser/themes/osx/places/editBookmark.css#59,62,64-67

- toolkit/themes/osx/global/checkbox/cbox-check.gif can be removed as well

- https://searchfox.org/mozilla-central/rev/fd32b3a6fa3eff1468311f6fcf32b45c117136df/toolkit/themes/osx/global/jar.mn#49

You'll also need to replace https://searchfox.org/mozilla-central/source/accessible/tests/mochitest/treeview.css#2 with url("chrome://global/skin/icons/check.svg")
Priority: -- → P3
Hi Tim,

I'd like to take this up and work on it.
Assignee: nobody → nevetia.vedant
Assigned it to you, please let me know if you have any questions!
Hi Tim. I've made the necessary changes. Please let me know if anything else needs to be changed. Thanks!
Attachment #9033532 - Attachment description: Bug 1514175 Remove macOS fallback styling for the bookmarking panel tag selector checkboxes → Bug 1514175 - Remove macOS fallback styling for the bookmarking panel tag selector checkboxes
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/53ebd07fd26e
Remove macOS fallback styling for the bookmarking panel tag selector checkboxes r=dao
https://hg.mozilla.org/mozilla-central/rev/53ebd07fd26e
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: