Don't create PanZoomController lazily

RESOLVED FIXED in Firefox 66

Status

defect
P1
normal
RESOLVED FIXED
6 months ago
5 months ago

People

(Reporter: snorp, Assigned: snorp)

Tracking

(Blocks 1 bug)

unspecified
mozilla66
Dependency tree / graph

Firefox Tracking Flags

(firefox64 wontfix, firefox65 wontfix, firefox66 fixed)

Details

Attachments

(1 attachment)

Right now we only create `PanZoomController` (and consequently attach it to the session) if it's explicitly requested via `GeckoSession.getPanZoomController`. This causes crashes in mochitest due to nsWindow::NativeTouchPoint` wanting to use it. We should just create unconditionally to avoid this problem. After all, it's pretty likely that we're going to want to send input.
Assignee: nobody → snorp

Comment 2

6 months ago
Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9bfabcea5227
Create PanZoomController immediately in GeckoSession r=geckoview-reviewers,droeh#geckoview-reviewers
Backed out changeset for geckoview crashes on geckoview.test.SessionLifecycleTest.readFromParcel_closeOpenAndLoad

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&searchStr=gecko&revision=9bfabcea5227bc9bd751a12fb1594f1b78ae8916&selectedJob=217111495

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=217111495&repo=autoland&lineNumber=2541

Backout link: https://hg.mozilla.org/integration/autoland/rev/dc998af2b5fdbc8a9177b3836a97de92e5f1da52

task 2018-12-14T23:01:27.960Z] 23:01:27     INFO -  TEST-START | org.mozilla.geckoview.test.SessionLifecycleTest.readFromParcel_closeOpenAndLoad
[task 2018-12-14T23:01:42.888Z] 23:01:42     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_RESULT: shortMsg=Process crashed.
[task 2018-12-14T23:01:42.889Z] 23:01:42     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_CODE: 0
[task 2018-12-14T23:01:43.290Z] 23:01:43     INFO -  Passed: 61
[task 2018-12-14T23:01:43.290Z] 23:01:43     INFO -  Failed: 0
[task 2018-12-14T23:01:43.291Z] 23:01:43     INFO -  Todo: 6
[task 2018-12-14T23:01:43.291Z] 23:01:43     INFO -  SUITE-END | took 896s
[task 2018-12-14T23:01:44.208Z] 23:01:44     INFO -  mozcrash Saved minidump as /builds/worker/workspace/build/blobber_upload_dir/543ec890-f22b-d589-a206-627d1c81f025.dmp
[task 2018-12-14T23:01:44.210Z] 23:01:44     INFO -  mozcrash Saved app info as /builds/worker/workspace/build/blobber_upload_dir/543ec890-f22b-d589-a206-627d1c81f025.extra
[task 2018-12-14T23:01:44.210Z] 23:01:44  WARNING -  PROCESS-CRASH | org.mozilla.geckoview.test.SessionLifecycleTest.readFromParcel_closeOpenAndLoad | application crashed [None]
[task 2018-12-14T23:01:44.210Z] 23:01:44     INFO -  Crash dump filename: /tmp/tmp2HCeMi/543ec890-f22b-d589-a206-627d1c81f025.dmp
[task 2018-12-14T23:01:44.211Z] 23:01:44     INFO -  MINIDUMP_STACKWALK binary not found: linux64-minidump_stackwalk
[task 2018-12-14T23:01:44.211Z] 23:01:44     INFO -  Stopping web server
[task 2018-12-14T23:01:44.218Z] 23:01:44     INFO -  Stopping web socket server
[task 2018-12-14T23:01:44.238Z] 23:01:44     INFO -  Stopping ssltunnel
[task 2018-12-14T23:01:46.290Z] 23:01:46    ERROR - Return code: 1
[task 2018-12-14T23:01:46.290Z] 23:01:46     INFO - TinderboxPrint: geckoview-junit<br/>61/0&nbsp;<em class="testfail">CRASH</em>
[task 2018-12-14T23:01:46.290Z] 23:01:46     INFO - ##### geckoview-junit log ends
[task 2018-12-14T23:01:46.291Z] 23:01:46  WARNING - # TBPL WARNING #
[task 2018-12-14T23:01:46.291Z] 23:01:46  WARNING - setting return code to 1
Flags: needinfo?(snorp)

Updated

6 months ago
Product: Firefox for Android → GeckoView
Flags: needinfo?(snorp)
P1 because this bug is needed for mochitests.
Priority: -- → P1

(In reply to Cosmin Sabou [:CosminS] from comment #3)

Backed out changeset for geckoview crashes on
geckoview.test.SessionLifecycleTest.readFromParcel_closeOpenAndLoad

James, your PanZoomController fix was backed out for crashing tests.

Flags: needinfo?(snorp)

(In reply to Chris Peterson [:cpeterson] from comment #5)

(In reply to Cosmin Sabou [:CosminS] from comment #3)

Backed out changeset for geckoview crashes on
geckoview.test.SessionLifecycleTest.readFromParcel_closeOpenAndLoad

James, your PanZoomController fix was backed out for crashing tests.

Yeah, I had a new patch I tried to reland, but looks like the merge failed. I'll get it fixed up today.

Flags: needinfo?(snorp)

Comment 7

5 months ago
Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/821f274155c7
Create PanZoomController immediately in GeckoSession r=geckoview-reviewers,droeh#geckoview-reviewers

Comment 8

5 months ago
bugherder
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.