Closed
Bug 1514263
Opened 5 years ago
Closed 5 years ago
UnboxedPlainObject::convertToNative needs to enter the object's realm
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
With bug 1514210 we fail the realm assert in UnboxedLayout::makeNativeGroup on browser tests on Try. It should be possible to write a shell test for this.
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → jdemooij
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•5 years ago
|
||
We were failing the realm assert in UnboxedLayout::makeNativeGroup in the browser. It's possible the assert is overzealous and we don't need the AutoRealm, but this makes it much easier to reason about the code.
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fea0ebc9d0ac Enter the object's realm in UnboxedPlainObject::convertToNative. r=bhackett
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fea0ebc9d0ac
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•