UnboxedPlainObject::convertToNative needs to enter the object's realm

RESOLVED FIXED in Firefox 66

Status

()

enhancement
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

unspecified
mozilla66
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(1 attachment)

With bug 1514210 we fail the realm assert in UnboxedLayout::makeNativeGroup on browser tests on Try. It should be possible to write a shell test for this.
Assignee: nobody → jdemooij
Status: NEW → ASSIGNED
We were failing the realm assert in UnboxedLayout::makeNativeGroup in the browser.
It's possible the assert is overzealous and we don't need the AutoRealm, but this
makes it much easier to reason about the code.
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fea0ebc9d0ac
Enter the object's realm in UnboxedPlainObject::convertToNative. r=bhackett
https://hg.mozilla.org/mozilla-central/rev/fea0ebc9d0ac
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.