1514346 - Add --enable-gczeal to fuzzing builds

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Steve Fink [:sfink] [:s:]]

As discussed on IRC and bug 1509923.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Add --enable-gczeal to fuzzing builds

Survived a local `.../autospider.py fuzzing` build.

Comment 2

[Christian Holler (:decoder)]

Comment on attachment 9031555 [details] [diff] [review]
Add --enable-gczeal to fuzzing builds

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b6d7250b9df3
Add --enable-gczeal to fuzzing builds, r=decoder

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset b6d7250b9df3 (Bug 1514346) for sm fuzzing build bustage.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=b6d7250b9df350bbd32a904076e8c3bcd76ff4fe&selectedJob=217212467

Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/8a6afcb74cd9cc711a601fad300be5e6b0493c2a

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=217213380&repo=mozilla-inbound&lineNumber=734

[task 2018-12-15T16:39:09.770Z] /builds/worker/workspace/clang/bin/clang++ -o Unified_cpp_js_src_gc2.o -c  -I/builds/worker/workspace/build/src/obj-spider/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DENABLE_BINARYDATA -DENABLE_WASM_BULKMEM_OPS -DENABLE_WASM_GC -DENABLE_WASM_GENERALIZED_TABLES -DWASM_PRIVATE_REFTYPES -DWASM_HUGE_MEMORY -DJS_CACHEIR_SPEW -DJS_STRUCTURED_SPEW -DJS_HAS_CTYPES -DFFI_BUILDING -DEXPORT_JS_API -DMOZ_HAS_MOZGLUE -I/builds/worker/workspace/build/src/js/src/gc -I/builds/worker/workspace/build/src/obj-spider/js/src/gc -I/builds/worker/workspace/build/src/obj-spider/js/src -I/builds/worker/workspace/build/src/js/src -I/builds/worker/workspace/build/src/obj-spider/dist/include -I/builds/worker/workspace/build/src/obj-spider/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-spider/js/src/js-confdefs.h -Qunused-arguments -U_FORTIFY_SOURCE -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-noexcept-type -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -fsanitize=address -U_FORTIFY_SOURCE -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -gline-tables-only -gdwarf-2 -O3 -fno-omit-frame-pointer -funwind-tables -Werror -fno-strict-aliasing -Werror=format -Wno-shadow  -MD -MP -MF .deps/Unified_cpp_js_src_gc2.o.pp   /builds/worker/workspace/build/src/obj-spider/js/src/gc/Unified_cpp_js_src_gc2.cpp
[task 2018-12-15T16:39:09.887Z]    Compiling memchr v2.0.1
[task 2018-12-15T16:39:09.887Z]      Running `/builds/worker/workspace/rustc/bin/rustc --crate-name memchr /builds/worker/workspace/build/src/third_party/rust/memchr/src/lib.rs --color never --crate-type lib --emit=dep-info,link -C opt-level=2 -C codegen-units=1 --cfg 'feature="default"' --cfg 'feature="libc"' --cfg 'feature="use_std"' -C metadata=a73052cced3a3daa -C extra-filename=-a73052cced3a3daa --out-dir /builds/worker/workspace/build/src/obj-spider/js/src/frontend/binsource/./release/deps -L dependency=/builds/worker/workspace/build/src/obj-spider/js/src/frontend/binsource/./release/deps --extern libc=/builds/worker/workspace/build/src/obj-spider/js/src/frontend/binsource/./release/deps/liblibc-443ad3fcea9c2757.rlib --cap-lints warn`
[task 2018-12-15T16:39:10.155Z]    Compiling atty v0.2.11
[task 2018-12-15T16:39:10.155Z]      Running `/builds/worker/workspace/rustc/bin/rustc --crate-name atty /builds/worker/workspace/build/src/third_party/rust/atty/src/lib.rs --color never --crate-type lib --emit=dep-info,link -C opt-level=2 -C codegen-units=1 -C metadata=971908c5c7d8ecbf -C extra-filename=-971908c5c7d8ecbf --out-dir /builds/worker/workspace/build/src/obj-spider/js/src/frontend/binsource/./release/deps -L dependency=/builds/worker/workspace/build/src/obj-spider/js/src/frontend/binsource/./release/deps --extern libc=/builds/worker/workspace/build/src/obj-spider/js/src/frontend/binsource/./release/deps/liblibc-443ad3fcea9c2757.rlib --cap-lints warn`
[task 2018-12-15T16:39:10.271Z]    Compiling memchr v1.0.2
[task 2018-12-15T16:39:10.271Z]      Running `/builds/worker/workspace/rustc/bin/rustc --crate-name memchr /builds/worker/workspace/build/src/third_party/rust/memchr-1.0.2/src/lib.rs --color never --crate-type lib --emit=dep-info,link -C opt-level=2 -C codegen-units=1 --cfg 'feature="default"' --cfg 'feature="libc"' --cfg 'feature="use_std"' -C metadata=b49189bf001cb857 -C extra-filename=-b49189bf001cb857 --out-dir /builds/worker/workspace/build/src/obj-spider/js/src/frontend/binsource/./release/deps -L dependency=/builds/worker/workspace/build/src/obj-spider/js/src/frontend/binsource/./release/deps --extern libc=/builds/worker/workspace/build/src/obj-spider/js/src/frontend/binsource/./release/deps/liblibc-443ad3fcea9c2757.rlib --cap-lints warn`
[task 2018-12-15T16:39:10.520Z]    Compiling phf_shared v0.7.21
[task 2018-12-15T16:39:10.520Z]      Running `/builds/worker/workspace/rustc/bin/rustc --crate-name phf_shared /builds/worker/workspace/build/src/third_party/rust/phf_shared/src/lib.rs --color never --crate-type lib --emit=dep-info,link -C opt-level=2 -C codegen-units=1 -C metadata=1e6a2e28112efe2b -C extra-filename=-1e6a2e28112efe2b --out-dir /builds/worker/workspace/build/src/obj-spider/js/src/frontend/binsource/./release/deps -L dependency=/builds/worker/workspace/build/src/obj-spider/js/src/frontend/binsource/./release/deps --extern siphasher=/builds/worker/workspace/build/src/obj-spider/js/src/frontend/binsource/./release/deps/libsiphasher-de82b64f3826f92a.rlib --cap-lints warn`
[task 2018-12-15T16:39:10.708Z]    Compiling proc-macro2 v0.4.9
[task 2018-12-15T16:39:10.708Z]      Running `/builds/worker/workspace/rustc/bin/rustc --crate-name proc_macro2 /builds/worker/workspace/build/src/third_party/rust/proc-macro2/src/lib.rs --color never --crate-type lib --emit=dep-info,link -C opt-level=2 -C codegen-units=1 --cfg 'feature="default"' --cfg 'feature="proc-macro"' -C metadata=65d20e2eaeeffe6f -C extra-filename=-65d20e2eaeeffe6f --out-dir /builds/worker/workspace/build/src/obj-spider/js/src/frontend/binsource/./release/deps -L dependency=/builds/worker/workspace/build/src/obj-spider/js/src/frontend/binsource/./release/deps --extern unicode_xid=/builds/worker/workspace/build/src/obj-spider/js/src/frontend/binsource/./release/deps/libunicode_xid-e7dad452200b1311.rlib --cap-lints warn`
[task 2018-12-15T16:39:11.536Z]    Compiling proc-macro2 v0.3.5
[task 2018-12-15T16:39:11.536Z]      Running `/builds/worker/workspace/rustc/bin/rustc --crate-name proc_macro2 /builds/worker/workspace/build/src/third_party/rust/proc-macro2-0.3.5/src/lib.rs --color never --crate-type lib --emit=dep-info,link -C opt-level=2 -C codegen-units=1 --cfg 'feature="default"' --cfg 'feature="proc-macro"' -C metadata=9a11e209f11415bb -C extra-filename=-9a11e209f11415bb --out-dir /builds/worker/workspace/build/src/obj-spider/release/deps -L dependency=/builds/worker/workspace/build/src/obj-spider/release/deps --extern unicode_xid=/builds/worker/workspace/build/src/obj-spider/release/deps/libunicode_xid-e7dad452200b1311.rlib --cap-lints warn`
[task 2018-12-15T16:39:12.268Z] In file included from /builds/worker/workspace/build/src/obj-spider/js/src/gc/Unified_cpp_js_src_gc2.cpp:2:
[task 2018-12-15T16:39:12.268Z] /builds/worker/workspace/build/src/js/src/gc/Verifier.cpp:762:13: error: unused variable 'object' [-Werror,-Wunused-variable]
[task 2018-12-15T16:39:12.268Z]   JSObject* object = map->memberOf;
[task 2018-12-15T16:39:12.268Z]             ^
[task 2018-12-15T16:39:13.467Z] /builds/worker/workspace/clang/bin/clang++ -o Unified_cpp_js_src_jit1.o -c  -I/builds/worker/workspace/build/src/obj-spider/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DENABLE_BINARYDATA -DENABLE_WASM_BULKMEM_OPS -DENABLE_WASM_GC -DENABLE_WASM_GENERALIZED_TABLES -DWASM_PRIVATE_REFTYPES -DWASM_HUGE_MEMORY -DJS_CACHEIR_SPEW -DJS_STRUCTURED_SPEW -DJS_HAS_CTYPES -DFFI_BUILDING -DEXPORT_JS_API -DMOZ_HAS_MOZGLUE -I/builds/worker/workspace/build/src/js/src/jit -I/builds/worker/workspace/build/src/obj-spider/js/src/jit -I/builds/worker/workspace/build/src/obj-spider/js/src -I/builds/worker/workspace/build/src/js/src -I/builds/worker/workspace/build/src/obj-spider/dist/include -I/builds/worker/workspace/build/src/obj-spider/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-spider/js/src/js-confdefs.h -Qunused-arguments -U_FORTIFY_SOURCE -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-noexcept-type -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -fsanitize=address -U_FORTIFY_SOURCE -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -gline-tables-only -gdwarf-2 -O3 -fno-omit-frame-pointer -funwind-tables -Werror -fno-strict-aliasing -Werror=format -Wno-shadow  -MD -MP -MF .deps/Unified_cpp_js_src_jit1.o.pp   /builds/worker/workspace/build/src/obj-spider/js/src/jit/Unified_cpp_js_src_jit1.cpp
[task 2018-12-15T16:39:14.032Z] 1 error generated.
[task 2018-12-15T16:39:14.045Z] /builds/worker/workspace/build/src/config/rules.mk:1131: recipe for target 'Unified_cpp_js_src_gc2.o' failed
[task 2018-12-15T16:39:14.045Z] make[3]: *** [Unified_cpp_js_src_gc2.o] Error 1
[task 2018-12-15T16:39:14.045Z] make[3]: Leaving directory '/builds/worker/workspace/build/src/obj-spider/js/src/gc'
[task 2018-12-15T16:39:14.045Z] /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'js/src/gc/target' failed
[task 2018-12-15T16:39:14.045Z] make[2]: *** [js/src/gc/target] Error 2
[task 2018-12-15T16:39:14.045Z] make[2]: *** Waiting for unfinished jobs....
[task 2018-12-15T16:39:14.045Z] /builds/worker/workspace/clang/bin/clang++ -o Unified_cpp_js_src_jit10.o -c  -I/builds/worker/workspace/build/src/obj-spider/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DENABLE_BINARYDATA -DENABLE_WASM_BULKMEM_OPS -DENABLE_WASM_GC -DENABLE_WASM_GENERALIZED_TABLES -DWASM_PRIVATE_REFTYPES -DWASM_HUGE_MEMORY -DJS_CACHEIR_SPEW -DJS_STRUCTURED_SPEW -DJS_HAS_CTYPES -DFFI_BUILDING -DEXPORT_JS_API -DMOZ_HAS_MOZGLUE -I/builds/worker/workspace/build/src/js/src/jit -I/builds/worker/workspace/build/src/obj-spider/js/src/jit -I/builds/worker/workspace/build/src/obj-spider/js/src -I/builds/worker/workspace/build/src/js/src -I/builds/worker/workspace/build/src/obj-spider/dist/include -I/builds/worker/workspace/build/src/obj-spider/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-spider/js/src/js-confdefs.h -Qunused-arguments -U_FORTIFY_SOURCE -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-noexcept-type -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -fsanitize=address -U_FORTIFY_SOURCE -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -gline-tables-only -gdwarf-2 -O3 -fno-omit-frame-pointer -funwind-tables -Werror -fno-strict-aliasing -Werror=format -Wno-shadow  -MD -MP -MF .deps/Unified_cpp_js_src_jit10.o.pp   /builds/worker/workspace/build/src/obj-spider/js/src/jit/Unified_cpp_js_src_jit10.cpp
[task 2018-12-15T16:39:15.084Z]    Compiling unreachable v1.0.0
[task 2018-12-15T16:39:15.084Z]      Running `/builds/worker/workspace/rustc/bin/rustc --crate-name unreachable /builds/worker/workspace/build/src/third_party/rust/unreachable/src/lib.rs --color never --crate-type lib --emit=dep-info,link -C opt-level=2 -C codegen-units=1 -C metadata=7a8f790e0c963e21 -C extra-filename=-7a8f790e0c963e21 --out-dir /builds/worker/workspace/build/src/obj-spider/js/src/frontend/binsource/./release/deps -L dependency=/builds/worker/workspace/build/src/obj-spider/js/src/frontend/binsource/./release/deps --extern void=/builds/worker/workspace/build/src/obj-spider/js/src/frontend/binsource/./release/deps/libvoid-4dfade68e3b90290.rlib --cap-lints warn`
[task 2018-12-15T16:39:15.143Z]      Running `/builds/worker/workspace/build/src/obj-spider/js/src/frontend/binsource/./release/build/serde-0d1ae4aa826d2661/build-script-build`

Comment 6

[Christian Holler (:decoder)]

Attachment: Bug 1514346 - Add --enable-gczeal to fuzzing/asan jsshell builds. r?sfink

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3933252dff2a
Add --enable-gczeal to fuzzing/asan jsshell builds. r=sfink

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/3933252dff2a