Closed Bug 1514425 Opened 6 years ago Closed 3 months ago

Intermittent dom/payments/test/test_constructor.html | paymentMethods' length should be 1.

Categories

(Core :: DOM: Web Payments, defect, P5)

defect

Tracking

()

RESOLVED INCOMPLETE

People

(Reporter: intermittent-bug-filer, Unassigned)

References

Details

(Keywords: intermittent-failure, Whiteboard: [retriggered][stockwell disabled])

Attachments

(3 files)

Filed by: aciure [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=217135173&repo=mozilla-inbound https://queue.taskcluster.net/v1/task/RKpq-nZzQeqr2jt-h61kcA/runs/0/artifacts/public/logs/live_backing.log [task 2018-12-15T00:31:22.543Z] 00:31:22 INFO - TEST-PASS | dom/payments/test/test_constructor.html | PaymentRequest should be created [task 2018-12-15T00:31:22.544Z] 00:31:22 INFO - Buffered messages finished [task 2018-12-15T00:31:22.544Z] 00:31:22 INFO - TEST-UNEXPECTED-FAIL | dom/payments/test/test_constructor.html | paymentMethods' length should be 1. [task 2018-12-15T00:31:22.545Z] 00:31:22 INFO - SimpleTest.ok@https://example.com/tests/SimpleTest/SimpleTest.js:275:7 [task 2018-12-15T00:31:22.545Z] 00:31:22 INFO - testFailHandler@https://example.com/tests/dom/payments/test/test_constructor.html:20:5 [task 2018-12-15T00:31:22.546Z] 00:31:22 INFO - Async*@https://example.com/tests/dom/payments/test/test_constructor.html:17:17 [task 2018-12-15T00:31:22.547Z] 00:31:22 INFO - Not taking screenshot here: see the one that was previously logged [task 2018-12-15T00:31:22.547Z] 00:31:22 INFO - TEST-UNEXPECTED-FAIL | dom/payments/test/test_constructor.html | methodData.data should not exist. [task 2018-12-15T00:31:22.548Z] 00:31:22 INFO - SimpleTest.ok@https://example.com/tests/SimpleTest/SimpleTest.js:275:7 [task 2018-12-15T00:31:22.550Z] 00:31:22 INFO - testFailHandler@https://example.com/tests/dom/payments/test/test_constructor.html:20:5 [task 2018-12-15T00:31:22.551Z] 00:31:22 INFO - Async*@https://example.com/tests/dom/payments/test/test_constructor.html:17:17 [task 2018-12-15T00:31:22.552Z] 00:31:22 INFO - TEST-PASS | dom/payments/test/test_constructor.html | PaymentRequest should be created
This started after Bug 1497219 landed here http://tinyurl.com/y9a2jdjp. Eden please take a look over this. Thank you.
Flags: needinfo?(echuang)
Whiteboard: [retriggered]
Created a patch to disable this on linux.
Attachment #9032671 - Flags: review?(jmaher)
Attachment #9032671 - Flags: review?(jmaher) → review+
Whiteboard: [retriggered][stockwell disable-recommended] → [retriggered][stockwell disabled]
Pushed by ebalazs@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0b4364c5795d Disable test_constructor.html on linux for frequent failures. r=jmaher
Keywords: checkin-needed
There are 31 failures for this nug in the past 7 days. Affected platforms are osx-10-10 and windows10-64 Recent log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=219156354&repo=mozilla-inbound&lineNumber=7937 15:07:40 INFO - TEST-START | dom/payments/test/test_constructor.html 15:07:40 INFO - TEST-INFO | started process screencapture 15:07:40 INFO - TEST-INFO | screencapture: exit 0 15:07:40 INFO - Buffered messages logged at 15:07:40 15:07:40 INFO - TEST-PASS | dom/payments/test/test_constructor.html | PaymentRequest should be created 15:07:40 INFO - Buffered messages finished 15:07:40 INFO - TEST-UNEXPECTED-FAIL | dom/payments/test/test_constructor.html | paymentMethods' length should be 1. 15:07:40 INFO - SimpleTest.ok@https://example.com/tests/SimpleTest/SimpleTest.js:275:7 15:07:40 INFO - testFailHandler@https://example.com/tests/dom/payments/test/test_constructor.html:20:5 15:07:40 INFO - Async*@https://example.com/tests/dom/payments/test/test_constructor.html:17:17 15:07:40 INFO - Not taking screenshot here: see the one that was previously logged 15:07:40 INFO - TEST-UNEXPECTED-FAIL | dom/payments/test/test_constructor.html | methodData.data should not exist. 15:07:40 INFO - SimpleTest.ok@https://example.com/tests/SimpleTest/SimpleTest.js:275:7 15:07:40 INFO - testFailHandler@https://example.com/tests/dom/payments/test/test_constructor.html:20:5 15:07:40 INFO - Async*@https://example.com/tests/dom/payments/test/test_constructor.html:17:17
Hi! This was skipped on Linux but looking at the failure rate after that I think it needs to be skipped also on win10 and osx and I've made a patch for this. Thanks.
Assignee: nobody → csabou
Attachment #9034614 - Flags: review?(jmaher)
Attachment #9034614 - Flags: review?(jmaher) → review+
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a1f680c69689 Disable dom/payments/test/test_constructor.html on win and osx for frequent failures. r=jmaher
Keywords: checkin-needed
Assignee: csabou → nobody

There are 26 total failures in the last 7 days on windows7-32-shippable opt and windows7-32 pgo

Recent failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=237089085&repo=autoland&lineNumber=5561

05:15:40 INFO - TEST-START | dom/payments/test/test_constructor.html
05:15:40 INFO - TEST-INFO | started process screenshot
05:15:40 INFO - TEST-INFO | screenshot: exit 0
05:15:40 INFO - Buffered messages logged at 05:15:40
05:15:40 INFO - TEST-PASS | dom/payments/test/test_constructor.html | PaymentRequest should be created
05:15:40 INFO - Buffered messages finished
05:15:40 INFO - TEST-UNEXPECTED-FAIL | dom/payments/test/test_constructor.html | paymentMethods' length should be 1.
05:15:40 INFO - SimpleTest.ok@https://example.com/tests/SimpleTest/SimpleTest.js:275:18
05:15:40 INFO - testFailHandler@https://example.com/tests/dom/payments/test/test_constructor.html:20:5
05:15:40 INFO - Async*@https://example.com/tests/dom/payments/test/test_constructor.html:17:31
05:15:40 INFO - Not taking screenshot here: see the one that was previously logged
05:15:40 INFO - TEST-UNEXPECTED-FAIL | dom/payments/test/test_constructor.html | methodData.data should not exist.
05:15:40 INFO - SimpleTest.ok@https://example.com/tests/SimpleTest/SimpleTest.js:275:18
05:15:40 INFO - testFailHandler@https://example.com/tests/dom/payments/test/test_constructor.html:20:5
05:15:40 INFO - Async*@https://example.com/tests/dom/payments/test/test_constructor.html:17:31
05:15:40 INFO - TEST-PASS | dom/payments/test/test_constructor.html | PaymentRequest should be created

Eden are you still working on this?

Flags: needinfo?(echuang)
Flags: needinfo?(echuang)
Whiteboard: [retriggered][stockwell disabled] → [retriggered][stockwell needswork:owner]

There are 27 total failures in the last 7 days on windows7-32-shippable opt and windows7-32 debug and opt.

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=241677318&repo=autoland&lineNumber=5364

08:22:43 INFO - TEST-START | dom/payments/test/test_constructor.html
08:22:43 INFO - TEST-INFO | started process screenshot
08:22:43 INFO - TEST-INFO | screenshot: exit 0
08:22:43 INFO - Buffered messages logged at 08:22:43
08:22:43 INFO - TEST-PASS | dom/payments/test/test_constructor.html | PaymentRequest should be created
08:22:43 INFO - Buffered messages finished
08:22:43 INFO - TEST-UNEXPECTED-FAIL | dom/payments/test/test_constructor.html | paymentMethods' length should be 1.
08:22:43 INFO - SimpleTest.ok@https://example.com/tests/SimpleTest/SimpleTest.js:275:18
08:22:43 INFO - testFailHandler@https://example.com/tests/dom/payments/test/test_constructor.html:20:5
08:22:43 INFO - Async*@https://example.com/tests/dom/payments/test/test_constructor.html:17:31
08:22:43 INFO - Not taking screenshot here: see the one that was previously logged
08:22:43 INFO - TEST-UNEXPECTED-FAIL | dom/payments/test/test_constructor.html | methodData.data should not exist.
08:22:43 INFO - SimpleTest.ok@https://example.com/tests/SimpleTest/SimpleTest.js:275:18
08:22:43 INFO - testFailHandler@https://example.com/tests/dom/payments/test/test_constructor.html:20:5
08:22:43 INFO - Async*@https://example.com/tests/dom/payments/test/test_constructor.html:17:31
08:22:43 INFO - TEST-PASS | dom/payments/test/test_constructor.html | PaymentRequest should be created
08:22:43 INFO - TEST-PASS | dom/payments/test/test_constructor.html | PaymentRequest should be created
08:22:43 INFO - TEST-PASS | dom/payments/test/test_constructor.html | Expected 'TypeError' with duplicate shippingOption Ids.
08:22:43 INFO - TEST-PASS | dom/payments/test/test_constructor.html | PaymentRequest with complex parameters should be created
08:22:43 INFO - TEST-PASS | dom/payments/test/test_constructor.html | PaymentRequest with simplest parameters should be created
08:22:43 INFO - TEST-PASS | dom/payments/test/test_constructor.html | Expected 'successful', but got 'successful'
08:22:43 INFO - TEST-PASS | dom/payments/test/test_constructor.html | PaymentRequest should be created
08:22:43 INFO - TEST-PASS | dom/payments/test/test_constructor.html | request.shippingOption should be null in default, when options.requestShipping is false
08:22:43 INFO - TEST-PASS | dom/payments/test/test_constructor.html | PaymentRequest should be created
08:22:43 INFO - TEST-PASS | dom/payments/test/test_constructor.html | request.shippingOption should be null in default, when options.requestShipping is false
08:22:43 INFO - TEST-PASS | dom/payments/test/test_constructor.html | PaymentRequest should be created
08:22:43 INFO - TEST-PASS | dom/payments/test/test_constructor.html | request.shippingOption should not be null when both shoppingOtpion.selected and options.requestOptions are true
08:22:43 INFO - TEST-PASS | dom/payments/test/test_constructor.html | request.shippingOption should be 'option1'
08:22:43 INFO - TEST-PASS | dom/payments/test/test_constructor.html | PaymentRequest should be created
08:22:43 INFO - TEST-PASS | dom/payments/test/test_constructor.html | request.shippingOption should not be null when both shoppingOtpion.selected and options.requestOptions are true
08:22:43 INFO - TEST-PASS | dom/payments/test/test_constructor.html | request.shippingOption should be 'option2' which is the last one selected.
08:22:43 INFO - GECKO(4968) | MEMORY STAT | vsize 451MB | vsizeMaxContiguous 1011MB | residentFast 65MB | heapAllocated 7MB
08:22:43 INFO - TEST-OK | dom/payments/test/test_constructor.html | took 110ms

Andrew, could you please assign this to someone?

Flags: needinfo?(echuang)
Flags: needinfo?(overholt)

We're not shipping Web Payments right now so I expect tests to regress. Can we ignore this directory?

Flags: needinfo?(overholt)

disable webpayment tests as we do not currently ship this feature

Assignee: nobody → jmaher

Eden, I am waiting for your review to disable these tests, can you take a look at it this week?

Flags: needinfo?(echuang)
Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e607a590c53c disable webpayment tests as we do not currently ship this feature. r=marcosc,edenchuang
Flags: needinfo?(echuang)

Can I assume, that the remaining two patches are not needed anymore then? Such that we can close this bug?

Flags: needinfo?(echuang)

The patch only disables the tests, it doesn't mean the bug is fixed.
I'd like to keep the bug open with low priority and set the assignee to nobody.
Keeping the bug open, and we can know the issue when we focus back on Web Payment project.

Assignee: jmaher → nobody
Flags: needinfo?(echuang)
Whiteboard: [retriggered][stockwell unknown] → [retriggered][stockwell disabled]
Severity: normal → S3

Bulk closing intermittent bugs for DOM LWS that have not seen new instances since at least 5 months.

Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → INCOMPLETE

Taking back the bulk change.

Status: RESOLVED → UNCONFIRMED
Ever confirmed: false
Resolution: INCOMPLETE → ---
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: leave-open

this was disabled 5 years ago, are we realistically going to work on webpayments again, or should we remove the tests and cleanup?

Flags: needinfo?(jstutte)

(In reply to Joel Maher ( :jmaher ) (UTC -8) from comment #40)

this was disabled 5 years ago, are we realistically going to work on webpayments again, or should we remove the tests and cleanup?

FYI, :mconca. I'd assume that removing the tests alone would not be the right call, if we keep the implementation.

Flags: needinfo?(jstutte) → needinfo?(mconca)

Web Payments has been discussed off and on over the years, and appears to be picking up some momentum (again). I'd encourage us to leave the tests and implementation (both disabled) for now.

Flags: needinfo?(mconca)
Status: NEW → RESOLVED
Closed: 10 months ago3 months ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: