1514447 - Consider removing TextComposition usages in widget/android

Status: NEW

(GeckoView :: General, enhancement, P3)

Description

[Makoto Kato [:m_kato]]

My understand is that TextComposition is for dom/base and dom/events, not widget.  So I guess that we shouldn't use TextComposition  in widget.  But widget/android still use it, so we should remove TextComposition usages in widget/android

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Yeah, I told about that, but there is still a lot of referrers in widget/android. If some of them are necessary, TextEventDispatcher should have them and should be referred by widget/android.

Comment 2

[Makoto Kato [:m_kato]]

(In reply to Masayuki Nakano [:masayuki] (JST, +0900) from comment #1)
> Yeah, I told about that, but there is still a lot of referrers in
> widget/android. If some of them are necessary, TextEventDispatcher should
> have them and should be referred by widget/android.

This is used for start offset and end offset of composition. So I think that we can remove TextCompositon dependency by storing offsets after dispatching composition and/or receiving composition handled.

Comment 3

[Chris Peterson [:cpeterson]]

Makoto, is this bug relevant for GV in Fenix? Or does this TextComposition code only affect Fennec?

Comment 4

[Makoto Kato [:m_kato]]

(In reply to Chris Peterson [:cpeterson] from comment #3)

Makoto, is this bug relevant for GV in Fenix? Or does this TextComposition code only affect Fennec?

Both, but this is for refactoring.

Comment 5

[David Lawrence [:dkl]]

Moving all open Core::Widget: Android bugs to GeckoView::General (then the triage owner of GeckoView will decide which ones are valuable and which ones should be closed).

Comment 6

[Chris Peterson [:cpeterson]]

Tasks and enhancements should have severity N/A.