1514503 - &brandShortName; not substituted in privacy preferences

Status: VERIFIED FIXED

(Mozilla Localizations :: de / German, defect)

Description

[Sören Hentzschel]

&brandShortName; is not substituted in the privacy preferences.

STR:

1. start a German Firefox
2. open about:preferences#privacy
3. In the history section change the option to "never remember history" ("niemals anlegen" in German Firefox)

Expected string:

Firefox wird dieselben Einstellungen wie im Privaten Modus verwenden und keinerlei Chronik anlegen, während Sie Firefox benutzen.

Actual string:

Firefox wird dieselben Einstellungen wie im Privaten Modus verwenden und keinerlei Chronik anlegen, während Sie &brandShortName; benutzen.

Regressed by bug 1446180 (Migrate the "Privacy" section of Preferences to the new Localization API).

The reason is that the translation "history-dontremember-description" in browser/browser/preferences/preferences.ftl is translated with:

{-brand-short-name} wird dieselben Einstellungen wie im Privaten Modus verwenden und keinerlei Chronik anlegen, während Sie &brandShortName; benutzen.

… instead of:

{-brand-short-name} wird dieselben Einstellungen wie im Privaten Modus verwenden und keinerlei Chronik anlegen, während Sie {-brand-short-name} benutzen.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Seems like an error in the german locale? (and a good candidate for a test? ;>)

Comment 2

[Francesco Lodolo [:flod]]

Thanks for reporting the bug.

(In reply to Zibi Braniecki [:gandalf][:zibi] from comment #1)
> Seems like an error in the german locale? (and a good candidate for a test?
> ;>)

Not sure what kind of test you're thinking of, but there are plenty of cases where a brand variable isn't used in the localization.

This string was migrated 9 months ago, in Firefox 61 (sigh…). At the time, we were only replacing the first occurrence of a placeholder in REPLACE(). German decided to use the brand name twice, creating an edge case that we discovered much later on.

en-US: { -brand-short-name } will use the same settings as private browsing, and will not remember any history as you browse the Web.

de: { -brand-short-name } wird dieselben Einstellungen wie im Privaten Modus verwenden und keinerlei Chronik anlegen, während Sie &brandShortName; benutzen.

I've fixed the string myself in Pontoon at this point.
https://pontoon.mozilla.org/de/firefox/browser/browser/preferences/preferences.ftl/?search=history-dontremember-description&string=177638

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Beta will eventually pick up this change, correct?

Comment 4

[Francesco Lodolo [:flod]]

Yes, it will be in the next Beta (already signed off).