Closed Bug 1514658 Opened 5 years ago Closed 5 years ago

Fix a few baseline alignment tests that makes bogus assumptions about line-height metrics

Categories

(Core :: Layout: Grid, defect, P4)

Product:
Core
Component:
Layout: Grid
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla66
Tracking Flags:
Tracking Status
firefox66 --- fixed

People

(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)

References

Details

Attachments

(1 file)

fix
5.42 KB, patch
emilio
: review+
Details | Diff | Splinter Review 
The following WPT tests are bogus because they depend on line-height metrics,
which differs between UAs:
/css/css-grid/alignment/grid-alignment-style-changes-005.html
/css/css-grid/alignment/grid-alignment-style-changes-006.html
/css/css-grid/alignment/grid-alignment-style-changes-007.html
/css/css-grid/alignment/grid-alignment-style-changes-008.html
Blocks: 1514265
Attached patch fix — — Splinter Review 

        Attachment #9031991 -
        Flags: review?(emilio)

    
    

    
  
Comment on attachment 9031991 [details] [diff] [review]
fix

Review of attachment 9031991 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fair, thanks!

        Attachment #9031991 -
        Flags: review?(emilio) → review+

    
    

    
  
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/21c134f346bb
Fix a few baseline alignment tests that makes bogus assumptions about line-height metrics.  r=emilio

    
    

    
  
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/14578 for changes under testing/web-platform/tests

    
    

    
  
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/21c134f346bb
Status: NEW → RESOLVED
Closed: 5 years ago

          status-firefox66:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: