1514803 - Partially deCOMtaminate gfxUtils::EncodeSourceSurface

Status: RESOLVED FIXED

(Core :: Graphics, enhancement, P3)

Description

[Barret Rennie [:barret] (they/them)]

`gfxUtils::EncodeSourceSurface` is used by the profiler to output screenshots. However, this function uses XPCOM to acquire the relevant encoder. On Windows platforms, this will be running in the GPU process, which cannot instantiate most XPCOM contracts (and adding a new exception here doesn't seem ideal). DeCOMtamination will solve this and we can get rid of a stringly-typed API in the process.

Comment 1

[Barret Rennie [:barret] (they/them)]

After further investigation, one of the code paths through this function makes
use of XPCOM to acquire an instance of a nsIClipboardHelper, which itself does
several XPCOM methods. This code path is not the code path that is executed
when the profiler is running, so I'm going to limit the scope of this work (for
now) to just acquiring the specific imgIEncoder for the specified image type
(which is what was not working on the GPU process on Windows and motivated this
work in the first place).

Comment 2

[Barret Rennie [:barret] (they/them)]

Attachment: Bug 1514803 - Expose nsPNGEncoder header r?aosmond

Comment 3

[Barret Rennie [:barret] (they/them)]

Attachment: Bug 1514803 - Export nsBMPEncoder r?aosmond

Depends on D14814

Comment 4

[Barret Rennie [:barret] (they/them)]

Attachment: Bug 1514803 - Export nsICOEncoder r?aosmond

Depends on D14815

Comment 5

[Barret Rennie [:barret] (they/them)]

Attachment: Bug 1514803 - Replace XPCOM image encoder instance creation in gfxUtils::EncodeSourceSurface r?jrmuizel

gfxUtils::EncodeSourceSurface no longer uses a stringly-typed API to create a
`imgIEncoder` for the relevant MIME type. Instead, we now use an enum class and
switch on it to create the encoder.

Depends on D14816

Comment 6

[Barret Rennie [:barret] (they/them)]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bdf903940004e6ed63690e1ad2d7de3d36167ad4

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a72d578c3a83
Expose nsPNGEncoder header r=aosmond
https://hg.mozilla.org/integration/autoland/rev/53a37a8d97ee
Export nsBMPEncoder r=aosmond
https://hg.mozilla.org/integration/autoland/rev/ebeed768822e
Export nsICOEncoder r=aosmond
https://hg.mozilla.org/integration/autoland/rev/cf9a58cbb904
Replace XPCOM image encoder instance creation in gfxUtils::EncodeSourceSurface r=jrmuizel

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/a72d578c3a83
https://hg.mozilla.org/mozilla-central/rev/53a37a8d97ee
https://hg.mozilla.org/mozilla-central/rev/ebeed768822e
https://hg.mozilla.org/mozilla-central/rev/cf9a58cbb904