Closed Bug 1514945 Opened 7 years ago Closed 2 years ago

Bookmark favicon disappear

Categories

(Toolkit :: Places, defect, P3)

Product:
Toolkit
Component:
Places
Version:
64 Branch
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: euthanasia_waltz, Unassigned)

References

Details

Favicon is removed and default globe icon displayed on some circumstances. This is a possible bug and I don't know actual case. However, it is reported at http://forums.mozillazine.org/viewtopic.php?p=14818415#p14818415, I guess. Steps to reproduce 1: 0. Start Firefox with fresh new profile. 1. Open https://store.steampowered.com/ 2. Bookmark it and make sure its favicon. 3. Open data:text/html,<html><head><link rel="shortcut icon" type="image/x-icon" href="https://store.steampowered.com/favicon.ico" /></head></html> 4. Open about:support and perform Verify Integrity. 5. Restart Firefox. Expected result: The bookmark has a favicon. Actual result: The bookmark doesn't have a favicon. Default globe icon displayed instead. Steps to reproduce 2: 0. Start Firefox with fresh new profile. 1. Open https://store.steampowered.com/ 2. Bookmark it and make sure its favicon. 3. Open test file having "<html><head><link rel="shortcut icon" type="image/x-icon" href="https://store.steampowered.com/favicon.ico" /></head></html>" on local web server.(I used node.js/http-server actually) 4. Clear Recent History. 5. Restart Firefox. Expected/Actual: same as above. Suspected bug 1468968. 'last release without'(20180725103029) doesn't have this issue and 'first release with'(20180726100339) has this issue.
Actual case found. 1. Open https://linuxmint.com/ and bookmark it. 2. Open http://developer.linuxmint.com/ 3. Clear history of 2.
Summary: (possible bug) Bookmark favicon disappear → Bookmark favicon disappear
(In reply to atlanto from comment #1) > Actual case found. > > 1. Open https://linuxmint.com/ and bookmark it. > 2. Open http://developer.linuxmint.com/ > 3. Clear history of 2. developer.linuxmint.com uses https://linuxmint.com/favicon.ico as icon, when clearing history for linuxmint.com the favicon is also removed because linuxmint.com origin goes away. It's likely this icon is root, but it's also associated as a normal icon to developer.linuxmint.com, our delete query doesn't check that, it just checks whether it's a root icon and the origin is gone. So, probably, what we could do is make the query also check if the icon is associated to some url, and not remove it in that case.
Blocks: 1468968
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P3

Another STR:

  1. Open https://www.ghacks.net/ and bookmark it.
  2. Open https://www.ghacks.net/favicon.ico
  3. Open about:support and perform Verify Integrity of Places Database section.
  4. Restart Firefox.
Severity: minor → S4

I think we're doing it correctly now.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.