Closed
Bug 1514990
Opened 6 years ago
Closed 6 years ago
Flex item sizing outline does not always rotate to match the item on the page
Categories
(DevTools :: Inspector, enhancement)
DevTools
Inspector
Tracking
(firefox66 verified)
VERIFIED
FIXED
Firefox 66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | verified |
People
(Reporter: pbro, Assigned: mtigley)
References
()
Details
Attachments
(2 files)
Screenshot 2018-12-18 at 10.23.43.png
In bug 1508613 we made it so that the flex sizing outline would always face the same direction the item does on the page.
There seems to be cases where that doesn't work however.
Here's one:
- open data:text/html,<body style="writing-mode:sideways-lr;"><div style="display:flex;background:red;inline-size: 400px;"><span style="flex-grow:1;max-inline-size:350px;">hello</span></div></body>
- select the <span> in the inspector
- notice that the outline is horizontal, left to right. But the body sets the writing-mode to sideways-lr.
I think the API we use returns vertical-bt for this direction, so the outline should also be vertical, bottom to top.
|
Reporter | |
Comment 1•6 years ago
|
||
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → mtigley
Status: NEW → ASSIGNED
|
||
Comment 2•6 years ago
|
||
(In reply to Patrick Brosset <:pbro> from comment #0)
> I think the API we use returns vertical-bt for this direction
Specifically the "mainAxisDirection" API:
https://searchfox.org/mozilla-central/rev/13788edbabb04d004e4a1ceff41d4de68a8320a2/dom/chrome-webidl/Flex.webidl#28-32
|
|
Assignee | |
Comment 3•6 years ago
|
||
|
|
Assignee | |
Comment 4•6 years ago
|
||
Pushed by mtigley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e1bac09e54c6
Rotate flex item sizing outline for items whose main axis direction is vertical-bt. r=pbro
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
|
||
Updated•6 years ago
|
Flags: qe-verify+
QA Contact: cristian.comorasu
|
||
Comment 7•6 years ago
|
||
I reproduced this issue using Fx 66.0a1 (2018-12-18), on Windows 10 x64.
I can confirm this issue is fixed, I verified using Fx 66.0b9, on Windows 10 x64, Ubuntu 14.04 LTS and macOS 10.13.
You need to log in
before you can comment on or make changes to this bug.
Description
•