1515001 - Debug build crashes with `privacy.spoof_english` set

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Georg Koppen]

Compiling Tor Browser in this case with `--enable-debug` results in an unusable bundle as we are hitting crashes during start-up:

Hit MOZ_CRASH(accessing non-early pref privacy.spoof_english before late prefs set) at /path/to/Preferences.cpp:932

tjr pointed dom/ipc/ContentPrefs.cpp and indeed doing something like

diff --git a/dom/ipc/ContentPrefs.cpp b/dom/ipc/ContentPrefs.cpp
index ac1ea10..87d4e2d 100644
--- a/dom/ipc/ContentPrefs.cpp
+++ b/dom/ipc/ContentPrefs.cpp
@@ -302,6 +302,7 @@ const char* mozilla::dom::ContentPrefs::gEarlyPrefs[] = {
   "privacy.resistFingerprinting.target_video_res",
   "privacy.resistFingerprinting.video_dropped_ratio",
   "privacy.resistFingerprinting.video_frames_per_sec",
+  "privacy.spoof_english",
   "privacy.trackingprotection.lower_network_priority",
   "privacy.window.maxInnerHeight",
   "privacy.window.maxInnerWidth",

Solves this bug.

Comment 1

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1515001 - Add privacy.spoof_english to the early content prefs to avoid a crash r?baku

Comment 2

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Comment on attachment 9032213 [details] [diff] [review]
Bug 1515001 - Add privacy.spoof_english to the early content prefs to avoid a crash r?baku

[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: Crashes Tor Browser

User impact if declined: Tor will have to carry another patch

Fix Landed on Version: n/a - only affects esr

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This only sends another pref to the Content Process on startup; it's not a functional change.

String or UUID changes made by this patch:

Comment 3

[Julien Cristau [:jcristau] (back April 22)]

Confused here.  Why request tracking for all the things if only esr60 is affected?

Comment 4

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

(In reply to Julien Cristau [:jcristau] from comment #3)
> Confused here.  Why request tracking for all the things if only esr60 is
> affected?

I messed up the flags - I was trying to say "Don't do anything for these versions" but I can only set '?' rather than '-'. I cleared the ?'s

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9032213 [details] [diff] [review]
Bug 1515001 - Add privacy.spoof_english to the early content prefs to avoid a crash r?baku

Simple crash fix for Tor users. Approved for 60.5.0esr.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/6ee4de0f59dc