Closed
Bug 1515006
Opened 5 years ago
Closed 5 years ago
[wpt-sync] Sync PR 14584 - SignedExchange: Use unparsed URL string for signature verification
Categories
(Testing :: web-platform-tests, enhancement, P4)
Testing
web-platform-tests
Tracking
(firefox67 fixed)
RESOLVED
FIXED
mozilla67
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 14584 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/14584 Details from upstream follow. Kunihiko Sakamoto <ksakamoto@chromium.org> wrote: > SignedExchange: Use unparsed URL string for signature verification > > Before this patch, SignedExchangeSignatureVerifier used GURL::spec() > to stringify URLs when reconstructing the signed message. However, > GURL::spec() may return a string which is differently percent-encoded > from the original URL string, and then verification fails. > > This patch introduces URLWithRawString struct which holds original > URL string along with parsed GURL, and use the original string > for signature verification. > > Bug: 914247 > Change-Id: I8950bf172391782ebb92338707245694b046052f > > Reviewed-on: https://chromium-review.googlesource.com/1377959 > WPT-Export-Revision: e0544a2e0e16047959d006a2372ab26ae95d4f67
Assignee | ||
Comment 1•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=3d0f532fd3dca35e6f1fbd22cd378fe14a0ca397
Assignee | ||
Comment 2•5 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b65de031c351d2484de130f353e863053f016ec
Assignee | ||
Comment 3•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=ef6a506bd04f2b3a4439b0c7634f2963381fa54c
Assignee | ||
Comment 4•5 years ago
|
||
Ran 2 tests and 2 subtests OK : 2 PASS : 1 FAIL : 1 New tests that have failures or other problems: /signed-exchange/sxg-utf8-inner-url.tentative.html SignedHTTPExchange with UTF-8 inner URL: FAIL
Assignee | ||
Comment 5•5 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=36a7eca0faa01130e6b4f4bf6ba22faa23806727
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/529e8ccefd82 [wpt PR 14584] - SignedExchange: Use unparsed URL string for signature verification, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/557a7bec5be9 [wpt PR 14584] - Update wpt metadata, a=testonly
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/af4e32dd875a [wpt PR 14584] - SignedExchange: Use unparsed URL string for signature verification, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/5a56714a6f54 [wpt PR 14584] - Update wpt metadata, a=testonly
Comment 8•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/af4e32dd875a
https://hg.mozilla.org/mozilla-central/rev/5a56714a6f54
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in
before you can comment on or make changes to this bug.
Description
•