[wpt-sync] Sync PR 14584 - SignedExchange: Use unparsed URL string for signature verification

RESOLVED FIXED in Firefox 67

Status

enhancement
P4
normal
RESOLVED FIXED
8 months ago
6 months ago

People

(Reporter: wptsync, Unassigned)

Tracking

unspecified
mozilla67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

(Whiteboard: [wptsync downstream], )

Sync web-platform-tests PR 14584 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14584
Details from upstream follow.

Kunihiko Sakamoto <ksakamoto@chromium.org> wrote:
>  SignedExchange: Use unparsed URL string for signature verification
>  
>  Before this patch, SignedExchangeSignatureVerifier used GURL::spec()
>  to stringify URLs when reconstructing the signed message. However,
>  GURL::spec() may return a string which is differently percent-encoded
>  from the original URL string, and then verification fails.
>  
>  This patch introduces URLWithRawString struct which holds original
>  URL string along with parsed GURL, and use the original string
>  for signature verification.
>  
>  Bug: 914247
>  Change-Id: I8950bf172391782ebb92338707245694b046052f
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1377959
>  WPT-Export-Revision: e0544a2e0e16047959d006a2372ab26ae95d4f67
Ran 2 tests and 2 subtests
OK     : 2
PASS   : 1
FAIL   : 1

New tests that have failures or other problems:
/signed-exchange/sxg-utf8-inner-url.tentative.html
    SignedHTTPExchange with UTF-8 inner URL: FAIL
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/529e8ccefd82
[wpt PR 14584] - SignedExchange: Use unparsed URL string for signature verification, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/557a7bec5be9
[wpt PR 14584] - Update wpt metadata, a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/af4e32dd875a
[wpt PR 14584] - SignedExchange: Use unparsed URL string for signature verification, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a56714a6f54
[wpt PR 14584] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.