Closed Bug 1515044 Opened 6 years ago Closed 6 years ago

Port "hidden focus" code to UrlbarInput.jsm (New Tab Search Bar breaks when both Quantum Bar and New Tab Search handoff are enabled)

Categories

(Firefox :: New Tab Page, defect, P2)

Product:
Firefox
Component:
New Tab Page
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 66
Iteration:
66.4 - Jan 21 - 27
Tracking Flags:
Tracking Status
firefox66 --- wontfix

People

(Reporter: dao, Assigned: rrosario)

References

Details

Attachments

(1 file)

Bug 1515044 - Port "hidden focus" code to UrlbarInput.jsm
47 bytes, text/x-phabricator-request
Details | Review
Bug 1514352 added code to urlbarBindings.xml but that's going away. That code needs to be ported to UrlbarInput.jsm.
Component: Activity Streams: Application Servers → Activity Streams: Newtab
Hi :dao, do you know what the timeline is for this deprecation?
Flags: needinfo?(dao+bmo)
I think we're likely to make the initial switch in Nightly this quarter.
Flags: needinfo?(dao+bmo)
Iteration: --- → 67.1 - Jan 28 - Feb 10
status-firefox66: affected → wontfix
Priority: -- → P2
Summary: Port "hidden focus" code to UrlbarInput.jsm → Port "hidden focus" code to UrlbarInput.jsm (New Tab Search Bar breaks when both Quantum Bar and New Tab Search handoff are enabled)
See Also: → 1520608

This is on pause, until bug 1520608 lands, since it may become pointless.

Assignee: nobody → rrosario
Iteration: 67.1 - Jan 28 - Feb 10 → 66.4 - Jan 21 - 27

MozReview-Commit-ID: GgYo2r9s5g4

Pushed by rrosario@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1c227ac918eb Port "hidden focus" code to UrlbarInput.jsm r=adw

Backed out changeset 1c227ac918eb (bug 1515044) for Browser-chrome in browser/components/urlbar/tests/browser/browser_UrlbarInput_hiddenFocus.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=223521490&repo=autoland&lineNumber=1259

INFO - TEST-START | browser/components/urlbar/tests/browser/browser_UrlbarInput_hiddenFocus.js
16:04:41 INFO - GECKO(7640) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to c:\users\task_1548258634\appdata\local\temp\tmpw4fwov.mozrunner\runtests_leaks_tab_pid2288.log
16:04:41 INFO - GECKO(7640) | [Child 2288, Main Thread] WARNING: No CID found when attempting to map contract ID: file z:/build/build/src/xpcom/components/nsComponentManager.cpp, line 594
16:04:41 INFO - GECKO(7640) | ++DOCSHELL 000001F1F6E4B000 == 1 [pid = 2288] [id = {8aff4473-1bc5-4895-b215-f3627f5c5e57}]
16:04:41 INFO - GECKO(7640) | ++DOMWINDOW == 1 (000001F1FC7A3800) [pid = 2288] [serial = 1] [outer = 0000000000000000]
16:04:41 INFO - GECKO(7640) | ++DOMWINDOW == 2 (000001F1FC7A6000) [pid = 2288] [serial = 2] [outer = 000001F1FC7A3800]
16:04:41 INFO - GECKO(7640) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to c:\users\task_1548258634\appdata\local\temp\tmpw4fwov.mozrunner\runtests_leaks_tab_pid3152.log
16:04:41 INFO - GECKO(7640) | [Child 3152, Main Thread] WARNING: No CID found when attempting to map contract ID: file z:/build/build/src/xpcom/components/nsComponentManager.cpp, line 594
16:04:41 INFO - GECKO(7640) | ++DOMWINDOW == 3 (000001F1FE779000) [pid = 2288] [serial = 3] [outer = 000001F1FC7A3800]
16:04:41 INFO - GECKO(7640) | [Parent 1076, Main Thread] WARNING: Found a principal with no URI, assuming third-party request: file z:/build/build/src/dom/base/ThirdPartyUtil.cpp, line 226
16:04:41 INFO - GECKO(7640) | [Parent 1076, Main Thread] WARNING: Found a principal with no URI, assuming third-party request: file z:/build/build/src/dom/base/ThirdPartyUtil.cpp, line 226
16:04:41 INFO - GECKO(7640) | [Parent 1076, Main Thread] WARNING: Found a principal with no URI, assuming third-party request: file z:/build/build/src/dom/base/ThirdPartyUtil.cpp, line 226
16:04:41 INFO - GECKO(7640) | ++DOCSHELL 0000012A0184B000 == 1 [pid = 3152] [id = {f973ed38-4520-46f0-9f41-a3be410de96c}]
16:04:41 INFO - GECKO(7640) | ++DOMWINDOW == 1 (0000012A032A5800) [pid = 3152] [serial = 1] [outer = 0000000000000000]
16:04:41 INFO - GECKO(7640) | ++DOMWINDOW == 2 (0000012A032A8000) [pid = 3152] [serial = 2] [outer = 0000012A032A5800]
16:04:41 INFO - GECKO(7640) | ++DOMWINDOW == 3 (0000012A09178C00) [pid = 3152] [serial = 3] [outer = 0000012A032A5800]
16:04:41 INFO - TEST-INFO | started process screenshot
16:04:41 INFO - TEST-INFO | screenshot: exit 0
16:04:41 INFO - Buffered messages logged at 16:04:41
16:04:41 INFO - Entering test bound
16:04:41 INFO - Buffered messages finished
16:04:41 INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_UrlbarInput_hiddenFocus.js | Uncaught exception - at chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_UrlbarInput_hiddenFocus.js:13 - TypeError: gURLBar.classList is undefined
16:04:41 INFO - Stack trace:
16:04:41 INFO - @chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_UrlbarInput_hiddenFocus.js:13:42
16:04:41 INFO - AsyncTester_execTest/<@chrome://mochikit/content/browser-test.js:1108:34
16:04:41 INFO - asyncTester_execTest@chrome://mochikit/content/browser-test.js:1099:16
16:04:41 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:992:9
16:04:41 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:803:59
16:04:41 INFO - Leaving test bound
16:04:41 INFO - GECKO(7640) | MEMORY STAT | vsize 1847MB | vsizeMaxContiguous 68122180MB | residentFast 296MB | heapAllocated 125MB
16:04:41 INFO - TEST-OK | browser/components/urlbar/tests/browser/browser_UrlbarInput_hiddenFocus.js | took 564ms
16:04:41 INFO - checking window state
16:04:41 INFO - GECKO(7640) | [Child 2288, Main Thread] WARNING: HTMLEditRules::BeforeEdit() failed to handle something: 'NS_SUCCEEDED(rv)', file z:/build/build/src/editor/libeditor/HTMLEditor.cpp, line 3576
16:04:41 INFO - GECKO(7640) | [Child 2288, Main Thread] WARNING: '!aSelection.RangeCount()', file z:/build/build/src/editor/libeditor/EditorBase.cpp, line 3569
16:04:41 INFO - GECKO(7640) | [Child 2288, Main Thread] WARNING: '!selectionStartPoint.IsSet()', file z:/build/build/src/editor/libeditor/HTMLEditRules.cpp, line 9806
16:04:41 INFO - GECKO(7640) | [Child 2288, Main Thread] WARNING: Failed to normalize Selection: 'NS_SUCCEEDED(rv)', file z:/build/build/src/editor/libeditor/HTMLEditRules.cpp, line 453
16:04:41 INFO - GECKO(7640) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to c:\users\task_1548258634\appdata\local\temp\tmpw4fwov.mozrunner\runtests_leaks_tab_pid2432.log
16:04:41 INFO - GECKO(7640) | [Child 2432, Main Thread] WARNING: No CID found when attempting to map contract ID: file z:/build/build/src/xpcom/components/nsComponentManager.cpp, line 594
16:04:41 INFO - GECKO(7640) | ++DOMWINDOW == 15 (0000017C1CC2C800) [pid = 1076] [serial = 15] [outer = 0000017C2C833C00]
16:04:41 INFO - GECKO(7640) | ++DOMWINDOW == 16 (0000017C30732800) [pid = 1076] [serial = 16] [outer = 0000017C2C833C00]
16:04:42 INFO - GECKO(7640) | --DOMWINDOW == 4 (000001F5104A1000) [pid = 1684] [serial = 2] [outer = 0000000000000000] [url = about:blank]
16:04:42 INFO - GECKO(7640) | ++DOCSHELL 000001E351F4B000 == 1 [pid = 2432] [id = {c8336335-4e5f-4194-be13-addcf2bd353f}]
16:04:42 INFO - GECKO(7640) | ++DOMWINDOW == 1 (000001E3579A5800) [pid = 2432] [serial = 1] [outer = 0000000000000000]
16:04:42 INFO - GECKO(7640) | --DOMWINDOW == 2 (0000012A032A8000) [pid = 3152] [serial = 2] [outer = 0000000000000000] [url = about:blank]
16:04:42 INFO - GECKO(7640) | --DOMWINDOW == 3 (000001EF65C97C00) [pid = 3336] [serial = 2] [outer = 0000000000000000] [url = about:blank]
16:04:42 INFO - GECKO(7640) | ++DOMWINDOW == 2 (000001E3579A8000) [pid = 2432] [serial = 2] [outer = 000001E3579A5800]
16:04:42 INFO - GECKO(7640) | --DOMWINDOW == 11 (00000222F5497000) [pid = 7096] [serial = 6] [outer = 0000000000000000] [url = about:blank]
16:04:42 INFO - GECKO(7640) | --DOMWINDOW == 10 (00000222F5497C00) [pid = 7096] [serial = 7] [outer = 0000000000000000] [url = about:blank]
16:04:42 INFO - GECKO(7640) | --DOMWINDOW == 9 (00000222EDBB5400) [pid = 7096] [serial = 8] [outer = 0000000000000000] [url = about:blank]
16:04:42 INFO - GECKO(7640) | --DOMWINDOW == 8 (00000222F34C5000) [pid = 7096] [serial = 5] [outer = 0000000000000000] [url = about:blank]
16:04:42 INFO - GECKO(7640) | --DOMWINDOW == 2 (000001F1FC7A6000) [pid = 2288] [serial = 2] [outer = 0000000000000000] [url = about:blank]
16:04:42 INFO - GECKO(7640) | [Child 1684, Main Thread] WARNING: 'NS_FAILED(rv)', file z:/build/build/src/dom/base/Element.cpp, line 1261
16:04:42 INFO - GECKO(7640) | --DOCSHELL 0000012A0184B000 == 0 [pid = 3152] [id = {f973ed38-4520-46f0-9f41-a3be410de96c}]
16:04:42 INFO - GECKO(7640) | --DOMWINDOW == 1 (0000012A09178C00) [pid = 3152] [serial = 3] [outer = 0000000000000000] [url = about:blank]
16:04:42 INFO - GECKO(7640) | --DOMWINDOW == 0 (0000012A032A5800) [pid = 3152] [serial = 1] [outer = 0000000000000000] [url = about:blank]
16:04:42 INFO - GECKO(7640) | --DOCSHELL 000001F5127CB000 == 1 [pid = 1684] [id = {db24ec0a-cfa2-41a3-b1f6-a27915bf8a48}]
16:04:42 INFO - GECKO(7640) | --DOMWINDOW == 3 (000001F512477400) [pid = 1684] [serial = 4] [outer = 0000000000000000] [url = about:blank]
16:04:42 INFO - GECKO(7640) | --DOMWINDOW == 2 (000001F50ACB8000) [pid = 1684] [serial = 5] [outer = 0000000000000000] [url = about:blank]
16:04:42 INFO - GECKO(7640) | --DOCSHELL 000001F50AC4A000 == 0 [pid = 1684] [id = {1a455e52-fdf5-4962-9f74-efe6258ef7d5}]
16:04:42 INFO - GECKO(7640) | --DOMWINDOW == 1 (000001F5104A0000) [pid = 1684] [serial = 1] [outer = 0000000000000000] [url = chrome://gfxsanity/content/sanitytest.html]
16:04:42 INFO - GECKO(7640) | --DOMWINDOW == 0 (000001F512479C00) [pid = 1684] [serial = 3] [outer = 0000000000000000] [url = chrome://gfxsanity/content/sanitytest.html]
16:04:42 INFO - GECKO(7640) | --DOCSHELL 000001EF6024A800 == 0 [pid = 3336] [id = {bf432bc5-1baf-490f-8e28-61a6a9b3595f}]
16:04:42 INFO - GECKO(7640) | --DOMWINDOW == 2 (000001EF65C97000) [pid = 3336] [serial = 3] [outer = 0000000000000000] [url = about:blank]
16:04:42 INFO - GECKO(7640) | --DOMWINDOW == 1 (000001EF67F90400) [pid = 3336] [serial = 4] [outer = 0000000000000000] [url = about:blank]
16:04:42 INFO - GECKO(7640) | --DOMWINDOW == 0 (000001EF65C96800) [pid = 3336] [serial = 1] [outer = 0000000000000000] [url = about:blank]
16:04:42 INFO - GECKO(7640) | --DOCSHELL 00000222EDB51800 == 3 [pid = 7096] [id = {fdad6025-319c-4255-a058-32a60146ebd5}]
16:04:42 INFO - GECKO(7640) | --DOMWINDOW == 7 (00000222F34C3C00) [pid = 7096] [serial = 4] [outer = 0000000000000000] [url = moz-extension://ba9d4e4e-4728-43cb-9935-6690562d38b0/_generated_background_page.html]
16:04:42 INFO - GECKO(7640) | --DOMWINDOW == 6 (00000222F576CC00) [pid = 7096] [serial = 12] [outer = 0000000000000000] [url = moz-extension://ba9d4e4e-4728-43cb-9935-6690562d38b0/_generated_background_page.html]
16:04:42 INFO - GECKO(7640) | --DOMWINDOW == 1 (000001F1FC7A3800) [pid = 2288] [serial = 1] [outer = 0000000000000000] [url = about:newtab]
16:04:42 INFO - GECKO(7640) | --DOCSHELL 000001F1F6E4B000 == 0 [pid = 2288] [id = {8aff4473-1bc5-4895-b215-f3627f5c5e57}]
16:04:42 INFO - GECKO(7640) | --DOMWINDOW == 0 (000001F1FE779000) [pid = 2288] [serial = 3] [outer = 0000000000000000] [url = about:newtab]
16:04:43 INFO - GECKO(7640) | --DOMWINDOW == 15 (0000017C2C667000) [pid = 1076] [serial = 10] [outer = 0000000000000000] [url = about:blank]
16:04:43 INFO - GECKO(7640) | --DOMWINDOW == 14 (0000017C293B5C00) [pid = 1076] [serial = 4] [outer = 0000000000000000] [url = about:blank]
16:04:43 INFO - GECKO(7640) | --DOMWINDOW == 13 (0000017C2E7A3800) [pid = 1076] [serial = 12] [outer = 0000000000000000] [url = about:blank]
16:04:43 INFO - GECKO(7640) | --DOMWINDOW == 12 (0000017C1CC2C800) [pid = 1076] [serial = 15] [outer = 0000000000000000] [url = about:blank]
16:04:43 INFO - GECKO(7640) | Completed ShutdownLeaks collections in process 3152
16:04:43 INFO - GECKO(7640) | Completed ShutdownLeaks collections in process 2432
16:04:43 INFO - GECKO(7640) | Completed ShutdownLeaks collections in process 1684
16:04:43 INFO - GECKO(7640) | Completed ShutdownLeaks collections in process 3336
16:04:44 INFO - GECKO(7640) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to c:\users\task_1548258634\appdata\local\temp\tmpw4fwov.mozrunner\runtests_leaks_tab_pid3252.log
16:04:44 INFO - GECKO(7640) | [Child 3252, Main Thread] WARNING: No CID found when attempting to map contract ID: file z:/build/build/src/xpcom/components/nsComponentManager.cpp, line 594
16:04:44 INFO - GECKO(7640) | Completed ShutdownLeaks collections in process 7096
16:04:44 INFO - GECKO(7640) | Completed ShutdownLeaks collections in process 2288
16:04:45 INFO - GECKO(7640) | Completed ShutdownLeaks collections in process 1076
16:04:45 INFO - TEST-START | Shutdown
16:04:45 INFO - Browser Chrome Test Summary
16:04:45 INFO - Passed: 0
16:04:45 INFO - Failed: 1
16:04:45 INFO - Todo: 0
16:04:45 INFO - Mode: e10s
16:04:45 INFO - *** End BrowserChrome Test Results ***

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=223517409&revision=1c227ac918eb1ab0b702d4424603faeb836f2b1c

Backout:
https://hg.mozilla.org/integration/autoland/rev/55db5268fa7527bb676dbaea070f7742b701c269

Flags: needinfo?(rrosario)

Yep, /me fixes the test.

Flags: needinfo?(rrosario)
Pushed by rrosario@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0e5aa503740c Port "hidden focus" code to UrlbarInput.jsm r=adw

https://hg.mozilla.org/mozilla-central/rev/0e5aa503740c

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: