1515083 - Re-implement telemetry for selected index/type on the new QuantumBar

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P2)

Description

[Mark Banner (:standard8)]

As part of the work for the new QuantumBar, we should ensure that the following telemetry probes continue working:

FX_URLBAR_SELECTED_RESULT_INDEX
FX_URLBAR_SELECTED_RESULT_INDEX_BY_TYPE
FX_URLBAR_SELECTED_RESULT_TYPE

Note: some of this may be able to be consolidated or combined with bug 1500476.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1515083 - Extend urlbar telemetry tests to cover most reported result types. r?adw

This add checks for everything bar 'preloaded-top-site' which isn't used/enabled at the moment (bug 1527888).

Depends on D19709

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1515083 - Re-implement telemetry for selected index/type on QuantumBar. r?adw

This makes the browser_UsageTelemetry_urlbar*.js tests pass for the all of the
FX_URLBAR_SELECTED_RESULT_* histograms apart from the "METHOD" one which will be handled
in bug 1500476.

I have handled the recording of telemetry in the controller, as this seems a better
location than BrowserUsageTelemetry.jsm due to needing to reach into the results and obtain
specific details.

Depends on D19784

Comment 3

[Mark Banner (:standard8)]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c98dc1e88b0f5de0c9366da6b720d78c1f305eaa

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e90244ffbb13
Extend urlbar telemetry tests to cover most reported result types. r=adw
https://hg.mozilla.org/integration/autoland/rev/a8d8de1df9e4
Re-implement telemetry for selected index/type on QuantumBar. r=adw

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e90244ffbb13
https://hg.mozilla.org/mozilla-central/rev/a8d8de1df9e4