Closed Bug 1515156 Opened 6 years ago Closed 6 years ago

Move tc-web/server into monorepo

Categories

(Taskcluster :: UI, enhancement)

Product:
Taskcluster
Component:
UI
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: dustin, Assigned: owlish)

References

Details

I don't think we've decided if tc-web will be in the monorepo, but tc-web-server probably should.
No longer blocks: tc-monorepo
Depends on: tc-monorepo
Hassan, is this something you can work on with me and owlish?
Flags: needinfo?(helfi92)
Assignee: nobody → bugzeeeeee
Definitely.
Flags: needinfo?(helfi92)

What I think needs to be done:

  1. Add services/web-server @helfi92 to .github/CODEOWNERS.
  2. Add taskcluster-web-server to .taskcluster.yml.
  3. Copy taskcluster-web-server into services/web-server while preserving git history.
  4. In services/web-server/package.json remove taskcluster- packages and the engines property since they are defined on the root.
  5. Remove services/web-server/.taskcluster.yml and services/web-server/.github/.

Once this is done, we should have taskcluster-web-server in heroku stop using taskcluster/taskcluster-web-server and use taskcluster/taskcluster instead.

Irene, is there anything I can help with re: moving tc-web-server to monorepo?

Flags: needinfo?(bugzeeeeee)

Thank you for those instructions, Hassan, although I can't admit the process wasn't clear to me. (I haven't started this one because I was busy with other tickets, not because I didn't know how to do this.) So, I am a bit confused: are you intending to finish this ticket yourself?

Flags: needinfo?(bugzeeeeee)
Flags: needinfo?(helfi92)

Sorry, I was asked to help in https://bugzilla.mozilla.org/show_bug.cgi?id=1515156#c1 and was just trying to do that. I definitely don't want to steal work from you :)

Flags: needinfo?(helfi92)
Status: NEW → ASSIGNED

Haha, no worries! Just got a bit confused who's doing what :)

ok, so I pushed something which seems to be starting (thank you for your help today, Hassan!). I don't think I have dev env set up correctly for the project - Hassan, it would be awesome if you pulled the branch and tried it as well (and rviewed the last commit too)

Flags: needinfo?(helfi92)

Added my comments on the pull-request.

Flags: needinfo?(helfi92)

tc-web-server is now part of the monorepo and works!

https://github.com/taskcluster/taskcluster/pull/74
https://github.com/taskcluster/taskcluster/pull/97
https://github.com/taskcluster/taskcluster/pull/107

All merged

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Blocks: docs
Component: Tools → UI and Tools
You need to log in before you can comment on or make changes to this bug.