Closed Bug 1515192 Opened 6 years ago Closed 6 years ago

Replace handcrafted FrameChildListIDs class with EnumSet.

Categories

(Core :: Layout, defect, P4)

defect

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

Details

Attachments

(1 file)

FrameChildListIDs class can be implemented by mozilla::EnumSet (with a few API changes) https://searchfox.org/mozilla-central/rev/13788edbabb04d004e4a1ceff41d4de68a8320a2/layout/generic/FrameChildList.h#24-52
The following APIs are changed. 1. Contains() needs to become contains(). (EnumSet's methods have lowercase names.) 2. Use list constructor rather than "|" like a plain enum. 3. Use operator+= instead of operator|=.
Pushed by aethanyc@gmail.com: https://hg.mozilla.org/integration/autoland/rev/2aeb562c9c1c Replace handcrafted FrameChildListIDs class with EnumSet. r=mats
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: