1515211 - Add "Manage Themes" link to customize page

Status: RESOLVED DUPLICATE of bug 1729534

(Firefox :: Toolbars and Customization, enhancement, P3)

Description

[Andrew Swan [:aswan]]

One of the themes we're offering in customize mode is called "Space Fantasy", this was apparently grabbed from AMO several years ago, but it has since been pulled from AMO.  (I don't know why, but its homepage https://addons.mozilla.org/en-US/firefox/addon/space-fantasy/ is now 404)

We ship an old copy of this theme embedded in the browser, the first question is simply whether we should continue to ship it?  Unshipping it would disrupt any users who have that theme set, but continuing to ship it feels like we're not honoring the theme author's intention...

We'll be doing some ad hoc migrations as part of converting lightweight themes to packaged themes so we could handle migrating this theme at the same time, the alternative would be to just reset any users of that theme to the default theme.

Even if we decide to keep shipping that theme for existing users, should we replace it in the customize menu so no new users select it?

Comment 1

[Andrew Swan [:aswan]]

On top of the issues with Space Fantasy, the Themes section of Customize doesn't currently handle packaged themes.  A couple of people (added to the cc list) are agitating to remove the Themes selection from Customize altogether rather than updating it to work with packaged themes.  If we did that, that would make the questions about Space Fantasy irrelevant.

Comment 2

[David Durst [:ddurst]]

On top of that, we're ultimately aiming to put management of themes and extensions in about:addons (where the rest of themes are), so it seems like any recommending of themes should happen there.

Comment 3

[Andrew Swan [:aswan]]

A fair amount of engineering work hinges on having a UI/UX decision here.  I'm actually not sure who is responsible here, adding Aaron as well...

Comment 4

[Andrew Swan [:aswan]]

Still waiting on a UX response. Note that over in bug 1525511, Kris is removing recommended themes from the customize page. If there's a desire from UX to do something else, please speak up quickly!

Comment 5

[bbell]

Having access to theme management in Customize is important, but the draw itself is redundant and broken.

1. Convert the Themes Button into a link that opens the themes page of about:addons in a new tab. Its label will need to say "Manage Theme."

2. Augment the themes page of about:addons, so the applied theme is more apparent, and a link for getting more/new themes obvious.

Aaron Benson Can you provide a mockup the the changes needed for about:addons?

Comment 6

[Aaron Benson]

(In reply to bbell from comment #5)

Having access to theme management in Customize is important, but the draw itself is redundant and broken.

1. Convert the Themes Button into a link that opens the themes page of about:addons in a new tab. Its label will need to say "Manage Theme."

2. Augment the themes page of about:addons, so the applied theme is more apparent, and a link for getting more/new themes obvious.

Aaron Benson Can you provide a mockup the the changes needed for about:addons?

Agreed on the approach here. I think Emanuela is the better point person, though, and it just so happens she and I are teamed up on the newly coined "Desktop UX" team. :) I'll NI the both of us and we'll follow up with design specs.

Comment 7

[Andrew Swan [:aswan]]

We never got an answer to what to do for any profiles using the built-in Space Fantasy theme so I'll assume its okay to remove it and just migrate users of it to the default theme. That will happen in bug 1471300 or bug 1525762. That leaves the two items from comment 6. I'd like to convert this bug to cover item #1, Emanuela or Aaron please file a new bug for the about:addons changes.

Comment 9

[Mathew Hodson]

This is a duplicate of bug 1729534 now I think.