1515257 - Move --with-system-libvpx to python configure

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1515257 - Remove VPX_X86_ASM.

It is used nowhere. Also remove the warning when there no assembly for
VPX. Barely anybody notices it, and there's nothing really noteworthy
about it.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1515257 - Remove VPX_ARM_ASM.

It is only used in one place, where it is redundant with VPX_AS_CONVERSION.

Depends on D14945

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1515257 - Don't pretend there are ARM assembly sources in libaom.

There aren't any, and the code to actually convert them from .asm to gas
that is expected by the moz.build is not even there, so if there were
assembly sources, it would fail to build.

Depends on D14946

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1515257 - Remove VPX_AS_CONVERSION.

There's only really one place where it's used, and we can "inline" it
there.

Depends on D14947

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1515257 - Add onerror argument to check_header().

Depends on D14948

Comment 6

[Mike Hommey [:glandium]]

Attachment: Bug 1515257 - Add a try_run method more generic than try_compile.

It will be useful to run tests like try_compile, with different flags and different
kinds of sources.

Depends on D14949

Comment 7

[Mike Hommey [:glandium]]

Attachment: Bug 1515257 - Add a check_symbol function that checks whether a symbol can be linked against.

Depends on D14950

Comment 8

[Mike Hommey [:glandium]]

Attachment: Bug 1515257 - Move --with-system-libvpx to python configure.

Depends on D14951

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b3e4e6b2744d
Remove VPX_X86_ASM. r=firefox-build-system-reviewers,ted
https://hg.mozilla.org/integration/autoland/rev/fc53b08bfb58
Remove VPX_ARM_ASM. r=firefox-build-system-reviewers,ted
https://hg.mozilla.org/integration/autoland/rev/2483ed8c7b82
Don't pretend there are ARM assembly sources in libaom. r=firefox-build-system-reviewers,ted
https://hg.mozilla.org/integration/autoland/rev/38e6668872ad
Remove VPX_AS_CONVERSION. r=firefox-build-system-reviewers,ted
https://hg.mozilla.org/integration/autoland/rev/85715bafc947
Add onerror argument to check_header(). r=firefox-build-system-reviewers,ted
https://hg.mozilla.org/integration/autoland/rev/f9f9a2746682
Add a try_run method more generic than try_compile. r=firefox-build-system-reviewers,ted
https://hg.mozilla.org/integration/autoland/rev/384ba32c3440
Add a check_symbol function that checks whether a symbol can be linked against. r=firefox-build-system-reviewers,ted
https://hg.mozilla.org/integration/autoland/rev/1a8798cea67c
Move --with-system-libvpx to python configure. r=firefox-build-system-reviewers,ted

Comment 10

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/b3e4e6b2744d
https://hg.mozilla.org/mozilla-central/rev/fc53b08bfb58
https://hg.mozilla.org/mozilla-central/rev/2483ed8c7b82
https://hg.mozilla.org/mozilla-central/rev/38e6668872ad
https://hg.mozilla.org/mozilla-central/rev/85715bafc947
https://hg.mozilla.org/mozilla-central/rev/f9f9a2746682
https://hg.mozilla.org/mozilla-central/rev/384ba32c3440
https://hg.mozilla.org/mozilla-central/rev/1a8798cea67c