Closed Bug 1515257 Opened 1 year ago Closed 1 year ago

Move --with-system-libvpx to python configure

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox66 fixed)

RESOLVED FIXED
Tracking Status
firefox66 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

(Blocks 1 open bug)

Details

Attachments

(8 files)

No description provided.
It is used nowhere. Also remove the warning when there no assembly for
VPX. Barely anybody notices it, and there's nothing really noteworthy
about it.
It is only used in one place, where it is redundant with VPX_AS_CONVERSION.

Depends on D14945
There aren't any, and the code to actually convert them from .asm to gas
that is expected by the moz.build is not even there, so if there were
assembly sources, it would fail to build.

Depends on D14946
There's only really one place where it's used, and we can "inline" it
there.

Depends on D14947
It will be useful to run tests like try_compile, with different flags and different
kinds of sources.

Depends on D14949
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/b3e4e6b2744d
Remove VPX_X86_ASM. r=firefox-build-system-reviewers,ted
https://hg.mozilla.org/integration/autoland/rev/fc53b08bfb58
Remove VPX_ARM_ASM. r=firefox-build-system-reviewers,ted
https://hg.mozilla.org/integration/autoland/rev/2483ed8c7b82
Don't pretend there are ARM assembly sources in libaom. r=firefox-build-system-reviewers,ted
https://hg.mozilla.org/integration/autoland/rev/38e6668872ad
Remove VPX_AS_CONVERSION. r=firefox-build-system-reviewers,ted
https://hg.mozilla.org/integration/autoland/rev/85715bafc947
Add onerror argument to check_header(). r=firefox-build-system-reviewers,ted
https://hg.mozilla.org/integration/autoland/rev/f9f9a2746682
Add a try_run method more generic than try_compile. r=firefox-build-system-reviewers,ted
https://hg.mozilla.org/integration/autoland/rev/384ba32c3440
Add a check_symbol function that checks whether a symbol can be linked against. r=firefox-build-system-reviewers,ted
https://hg.mozilla.org/integration/autoland/rev/1a8798cea67c
Move --with-system-libvpx to python configure. r=firefox-build-system-reviewers,ted
Blocks: 1251497
Blocks: 1257904
You need to log in before you can comment on or make changes to this bug.