1515487 - add ntdll.dll to prefix list

Status: RESOLVED FIXED

(Socorro :: Signature, task, P2)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Bug #1514028 covers a large group of crashes all with the signature:

shutdownhang | ntdll.dll@0x93294

That's unhelpful.

This bug covers breaking that bucket up into more distinct buckets. One thing we should try first is to add ntdll.dll to the prefix list so that signature generation continues beyond those frames.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

If I add these to prefix_signature_re.txt:

kernel32\.dll
ntdll\.dll
rpcrt4\.dll
user32\.dll

Then I get this:

app@73b0aa89b441:/app$ socorro-cmd fetch_crashids --num=10 --signature-contains=ntdll.dll | socorro-cmd signature
Crash id: 56b5081c-67e7-473e-8887-b525b0181219
Original: shutdownhang | ntdll.dll@0x90b80
New:      shutdownhang | ntdll.dll@0x90b80 | rpcrt4.dll@0x529b | rpcrt4.dll@0x8fd3 | AudiosrvTsUnregisterAudioProtocolNotification
Same?:    False
Crash id: 142b382e-bb1f-4764-a03f-a65510181219
Original: shutdownhang | ntdll.dll@0x46c04
New:      shutdownhang | ntdll.dll@0x46c04 | user32.dll@0x162c8 | mozilla::widget::WinUtils::WaitForMessage | nsAppShell::ProcessNextNativeEvent
Same?:    False
Crash id: 9e9d1e39-482b-43a9-8c72-2552c0181219
Original: shutdownhang | ntdll.dll@0x9e294
New:      shutdownhang | ntdll.dll@0x9e294 | ntdll.dll@0x25f28 | mozilla::SpinEventLoopUntil<T> | mozilla::dom::quota::QuotaManager::ShutdownObserver::Observe
Same?:    False
Crash id: 1334852b-9ba7-457c-b41a-49cc60181219
Original: shutdownhang | ntdll.dll@0x9e294
New:      shutdownhang | ntdll.dll@0x9e294 | ntdll.dll@0x25f28 | mozilla::SpinEventLoopUntil<T> | mozilla::dom::quota::QuotaManager::ShutdownObserver::Observe
Same?:    False
Crash id: f9785313-13f4-4ae9-8569-1e02d0181219
Original: shutdownhang | ntdll.dll@0x9fe04
New:      shutdownhang | ntdll.dll@0x9fe04 | GetFileAttributesW
Same?:    False
Crash id: e6a5fa78-aa00-4baa-b529-5ba9e0181219
Original: shutdownhang | ntdll.dll@0x9e294
New:      shutdownhang | ntdll.dll@0x9e294 | ntdll.dll@0x25f28 | mozilla::SpinEventLoopUntil<T> | mozilla::dom::quota::QuotaManager::ShutdownObserver::Observe
Same?:    False
Crash id: 25e7fd19-983b-4483-8dc4-1d08a0181219
Original: shutdownhang | ntdll.dll@0x9b184
New:      shutdownhang | ntdll.dll@0x9b184 | ReadProcessMemory
Same?:    False
Crash id: d2205e0e-ba48-4295-ad5b-77fef0181219
Original: hang | ntdll.dll@0x2018d
New:      hang | ntdll.dll@0x2018d | kernel32.dll@0x119fb | user32.dll@0x20881 | user32.dll@0x20b80 | F_1152915508___________________________________
Same?:    False
Crash id: 9720e05d-9ff0-472b-99e3-c7acc0181219
Original: hang | ntdll.dll@0x2018d
New:      hang | ntdll.dll@0x2018d | kernel32.dll@0x119fb | user32.dll@0x20881 | user32.dll@0x20b80 | F_1152915508___________________________________
Same?:    False
Crash id: b9707197-a3aa-45b2-a5b6-3960d0181219
Original: hang | ntdll.dll@0x1f901
New:      hang | ntdll.dll@0x1f901 | _allmul
Same?:    False


I think that breaks up that bucket into better buckets and maybe makes a few of those actionable. Seems better.

Ted: Does that sound like an ok thing to do to you? I'm pretty sure the issue here is that we're missing Windows symbols, so this is papering over the real issue until we fix the real issue every time the real issue pops up.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 4750: fix bug 1515487: add ntdll.dll and friends to prefix list

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

I did some more experimenting and decided to change the prefix list to include a generic dll line which will apply to all dlls. Further, I decided to nix the trim_dll_signatures_re.txt file and instead trim all dlls.

Adrian pointed out this comment

https://bugzilla.mozilla.org/show_bug.cgi?id=1274345#c4

That suggests this is the right thing to do.

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/b64eeb0832f140c5af6ed96a6ef867b63f945785
fix bug 1515487: add ntdll.dll and friends to prefix list

This adds several things to the prefix list which show up when we don't
have symbols. Adding them to the prefix list will produce better
signatures in some cases until we get symbols.

https://github.com/mozilla-services/socorro/commit/aae6aa0849d742b3a9cbcf8ffce2d4f1d11b5f98
fix bug 1515487: slim down dll handling in signature generation

This gets rid of trim_dll_signature_re.txt file and related code
opting instead for treating all .dlls that way.

https://github.com/mozilla-services/socorro/commit/b337b3598a2275ce7a55a12b1057f4c131ba71dc
Merge pull request #4750 from willkg/1514028-ntdll

fix bug 1515487: add ntdll.dll and friends to prefix list

Comment 5

[(not currently active) Ted Mielczarek]

Looks good!

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

I pushed the code out and reprocessed the last month of crash reports with "ntdll.dll" in the signature. There were 173,753 of them. Done!