1515590 - Various fixes for browser chrome tests for same-compartment realms

Status: RESOLVED FIXED

(Core :: XPConnect, enhancement, P2)

Description

[Jan de Mooij [:jandem]]

A bunch of relatively minor test and code changes to get these tests more green.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1515590 part 1 - Fix incorrect SandboxProxyHandler::getOwnPropertyDescriptor implementation. r?bzbarsky

The code was trying to implement the getOwnPropertyDescriptor trap in terms of
getPropertyDescriptor, by comparing the "holder" object we found to the object
we did the lookup on. This becomes buggy when wrappers like WindowProxy are involved.

The patch removes this check and calls JS_GetOwnPropertyDescriptor instead of
JS_GetPropertyDescriptor.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1515590 part 2 - Fix test_bug1042436.xul to create the sandbox in a new compartment because Xray warning state is stored per compartment. r?bholley

Depends on D15091

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1515590 part 3 - Fix some debugger tests by forcing separate compartments for the debugger and debuggee. r?ochameau

With same-compartment chrome globals these would end up in the same compartment.
We need to prevent that because the debugger doesn't support it.

Depends on D15092

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1515590 part 4 - Don't call FixWaiverAfterTransplant if JS_TransplantObject didn't change object identity. r?bholley

Depends on D15093

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/12f69be06d1e
part 1 - Fix incorrect SandboxProxyHandler::getOwnPropertyDescriptor implementation. r=bzbarsky

Comment 6

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/12f69be06d1e

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11d454511a09
part 2 - Fix test_bug1042436.xul to create the sandbox in a new compartment because Xray warning state is stored per compartment. r=bholley
https://hg.mozilla.org/integration/autoland/rev/4ebe565c65f9
part 3 - Fix some debugger tests by forcing separate compartments for the debugger and debuggee. r=ochameau
https://hg.mozilla.org/integration/autoland/rev/93ce93d1510d
part 4 - Don't call FixWaiverAfterTransplant if JS_TransplantObject didn't change object identity. r=bholley

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/11d454511a09
https://hg.mozilla.org/mozilla-central/rev/4ebe565c65f9
https://hg.mozilla.org/mozilla-central/rev/93ce93d1510d

Comment 9

[Jan de Mooij [:jandem]]

Attachment: Bug 1515590 part 5 - Fix test_bug771429.xul to work with same-compartment realms. r?bzbarsky

Changes the test to test both freshCompartment: true and freshCompartment: false
sandbox options.

There's one sub test that fails with same-copartment realms, I commented that
and added a weaker test for the same-compartment case.

Comment 10

[Jan de Mooij [:jandem]]

Attachment: Bug 1515590 part 6 - Fix AddSizeOfTab to reserve number-of-realms instead of number-of-compartments in the realms Vector. r?bzbarsky

ASan builds caught this.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd13046c9317
part 5 - Fix test_bug771429.xul to work with same-compartment realms. r=bzbarsky
https://hg.mozilla.org/integration/autoland/rev/d44fc9b89125
part 6 - Fix AddSizeOfTab to reserve number-of-realms instead of number-of-compartments in the realms Vector. r=bzbarsky

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/dd13046c9317
https://hg.mozilla.org/mozilla-central/rev/d44fc9b89125

Comment 13

[Jan de Mooij [:jandem]]

Attachment: Bug 1515590 part 7 - Null out proxy1 and proxy2 in test_jsterm_autocomplete.html to fix a shutdown leak. r?nchevobbe

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d16d586f9cd
part 7 - Null out proxy1 and proxy2 in test_jsterm_autocomplete.html to fix a shutdown leak. r=jlast

Comment 15

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/5d16d586f9cd

Comment 16

[Jan de Mooij [:jandem]]

Fingers crossed, but I think this is done.