1515683 - Netflix-player and Spotify-web player crash upon deleting page&download-history

Status: NEW

(Core :: Audio/Video: Playback, defect, P3)

Description

[Dan [:dan23]]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0

Steps to reproduce:

One method is:
1. Play a Netflix video in a browser tab.
2. Pause the video.
3. switch to another tab.
4. click on "history", and delete page & download-history (all).
5. go back to Netflix tab
6. click "play"


Actual results:

player crashes.


Expected results:

Should've resumed.

Comment 1

[Dan [:dan23]]

66.0a1 Nightly affected aswell.

Comment 2

[Matthias Versen [:Matti]]

Please provide a crash ID from a submitted crash (!) in about:crashes
- https://support.mozilla.org/en-US/kb/mozillacrashreporter

Comment 3

[Dan [:dan23]]

It's not Firefox.exe that crashes, just the player in the Netflix window. Or is it a Netflix bug, not a Firefox bug?

Comment 4

[Matthias Versen [:Matti]]

crash is a very specific term.
Do you mean that the netflix page in Firefox stops working after deleting the history ?
Does it work again if you reload netflix ?

In that case I would not call that a bug because the netflix page could use a (deleted) history entry to resume the playing.

Comment 5

[Dan [:dan23]]

Yes and yes. How would a page/website even be able to access a history entry in FF 64.0?

Comment 6

[Matthias Versen [:Matti]]

https://developer.mozilla.org/en-US/docs/Web/API/Window/history

Comment 7

[Dan [:dan23]]

So any website can read all previous websites from the current tab?

Comment 8

[Matthias Versen [:Matti]]

No, the website can only navigate back/forward but it can't read that other history entries. That would be a privacy violation.
I do not know if netflix uses this for his player and the pause function but I can't check that because it's a paid service.

Comment 9

[Dan [:dan23]]

Can you tell me how I can check it?

Comment 10

[Matthias Versen [:Matti]]

I would have told you that first if there would be an easy way

Comment 11

[Dan [:dan23]]

Do you know of any Firefox programmer who has netflix to test this?

Comment 12

[Hani Yacoub, Desktop QA]

I couldn't find the regression range, I went back to a build from April 2016 and I had the same problem after deleting the history, and when I tried to reproduce it on a build from January 2016 I got informed to use a newer version of FF.

I also tried on Chrome to see how things work there, and after deleting the history and switch back to Netflix tab the player resumes, but after I reloaded the page I was logged out which is expected.

I'm going to assigned it to "Core: Audio/Video: Playback" component.

Comment 13

[Michael Froman [:mjf]]

Jean-Yves, what is the expected behavior in this case?

Comment 14

[Jean-Yves Avenard [:jya]]

I tried the following:

Start playback in netflix.
Pause
Open a new tab. In it I go to history -> clear recent history, select last hour time range to clear (all checkboxes checked).
Go back to Netflix tab and resume

Playback resume.

Do those steps cause a problem for you?

Comment 15

[Jean-Yves Avenard [:jya]]

I tried the following:

Start playback in netflix.
Pause
Open a new tab. In it I go to history -> clear recent history, select last hour time range to clear (all checkboxes checked).
Go back to Netflix tab and resume

Playback resume.

Do those steps cause a problem for you?

(Funnily, this make bugzilla brokenish)

Comment 16

[Dan [:dan23]]

Jean, not even clear ALL, did you read my first post, I wrote "page & download-history (all)". ONLY deleting the page+download history (all time) makes the player crash sadly :/
So it definitely is related to deleted page / download-history (most likely page-history).

Comment 17

[Nils Ohlmeier [:drno]]

After choosing "History -> Clear Recent History -> Select 'Everything' & tick the boxes for 'Site Prefernces' and 'Offline Website Data'" and then switching back to the Netflix tab I got an "Ooops something went wrong" page with the Netflix error "Error Code: F7361-1253".

Daniel is this what you are seeing?

Comment 18

[Nils Ohlmeier [:drno]]

To answer previous questions about this: reloading the page after the "oops" results in Netflix no longer seeing me as logged in. Thus I can't continue to watch, except trailers (which work fine).

Comment 19

[Dan [:dan23]]

Yes, it's that exact "Oops something went wrong" message.

Comment 20

[Dan [:dan23]]

"fix-optional" meaning sb. is working on a fix?

Comment 21

[Julien Cristau [:jcristau]]

Afraid not. https://wiki.mozilla.org/Platform#Asynchronous_Regression_Tracking has a description.

Comment 22

[Dan [:dan23]]

Well? Netflix is the 17th most famous website in the world, if Firefox Release build doesn't work 100% with it, we'll lose users to Chrome... yes it's that easy.

Comment 23

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Hello ,

I tried and could not get a regression range . I went as far back as builds from 2015 and 2016 and the issue occurs in those builds with the exact STR.

Does not seem that this issue is a regression.

Comment 24

[Dan [:dan23]]

What's the next step now? Hotfix so that Netflix page history isn't deleted when user has a Netflix tab open?

Comment 25

[Dan [:dan23]]

P2 ? Meaning somebody is investigating?

Comment 26

[Dan [:dan23]]

steps 3 and 5 can be omitted, will crash aswell.

Comment 27

[Dan [:dan23]]

added Spotify web-player aswell, that one comes with a "Something went wrong with the playlist." error message.
Most likely other browser-webplayers of other brands affected aswell.

Comment 28

[Dan [:dan23]]

Probably needs some sort of "exception" for those websites, so that the last entry/few entries of those pages don't get deleted? (workaround)

Comment 29

[[:philipp]]

Daniel, please don't change the priority field unilaterally in bugs - this is set by developers who are triaging and scheduling work on issues.

Comment 30

[Dan [:dan23]]

Oh, okay. I'm sorry. It's just that I thought that it's quite easy to code a workaround that doesn't delete the last Netflix URL-entry-history to prevent the player from crashing.

Comment 31

[Dan]

Other browsers with a large userbase don't have this issue.

Comment 32

[BugBot [:suhaib / :marco/ :calixte]]

Change the status for beta to have the same as nightly and release.
For more information, please visit auto_nag documentation.

Comment 33

[Dan [:dan23]]

Still the case, both Netflix & Spotify, other browsers unaffected

.(In reply to Matthias Versen [:Matti] from comment #6)

https://developer.mozilla.org/en-US/docs/Web/API/Window/history

Thanks! I also searched for "window.history" on http://searchfox.org, do you know which file would need the exclusion added for netflix.com and spotify.com? (unless there's a better way to fix this)

Comment 34

[BugBot [:suhaib / :marco/ :calixte]]

Change the status for beta to have the same as nightly and release.
For more information, please visit auto_nag documentation.

Comment 35

[Matthias Versen [:Matti]]

(In reply to Dan from comment #33)

Thanks! I also searched for "window.history" on http://searchfox.org, do you know which file would need the exclusion added for netflix.com and spotify.com? (unless there's a better way to fix this)

Sorry but I can't help

Comment 36

[Dan [:dan23]]

Made an addon as workaround, for anyone interested. https://addons.mozilla.org/en-US/firefox/addon/clear-history-no-vod-crash/