1515686 - Update multi-selected tab colour so it's more visible in default theme

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P3)

Description

[Amy Lee [:amylee] UX]

Attachment: Screen Shot 2018-12-20 at 11.51.11.png

Update multi-selected tab colour so it's more visible in default theme. I've attached a spec for reference. Thanks.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Hi Amy,

The spec is a little confusing to me.

1. By "overlay" are you referring to the "tab-line"? This appears at the top of the tab and in your spec is blue.
2. For the background-color, you've proposed a solid color. We currently use a translucent color (#fff at .1 alpha) on top of the tab. This allows the themed color of the tab show through. If we move to a solid color, there is potential that we will conflict with a theme that has a similar solid color for the selected tab. I would prefer if we can keep a translucent color here.

Can you also please provide colors for background tabs that are showing black text in addition to the white text in the attached spec?

Thanks!

Comment 2

[Amy Lee [:amylee] UX]

(In reply to (away Dec 24-26, Dec 31-Jan 1) Jared Wein [:jaws] (Regression Engineering Owner for 65) (please needinfo? me) from comment #1)

> 
> 1. By "overlay" are you referring to the "tab-line"? This appears at the top
> of the tab and in your spec is blue.

No, I was referring to the translucent colour on top of the tab which you already explained is #fff .1 alpha.

> 2. For the background-color, you've proposed a solid color. We currently use
> a translucent color (#fff at .1 alpha) on top of the tab. This allows the
> themed color of the tab show through. If we move to a solid color, there is
> potential that we will conflict with a theme that has a similar solid color
> for the selected tab. I would prefer if we can keep a translucent color here.

Thanks for clarifying that the tab colour is inherited from a theme. What I am proposing is that multi-selected tabs inherit the focused tab colour instead of the unfocused tab colour and we have a translucent colour (#000000 at .1 alpha) on top.

Let me know if you see any issues with this.  

 
> Can you also please provide colors for background tabs that are showing
> black text in addition to the white text in the attached spec?

I haven't modified anything else except for the above request. 
 
> Thanks!

Hi Jared,

Comment 3

[Abdoulaye O. LY]

Hi, maybe I could help here when the spec is validated.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Does comment #2 clarify enough? This should be actionable now.

Comment 5

[Abdoulaye O. LY]

Yes, I think it is.

Comment 6

[Abdoulaye O. LY]

Attachment: Bug 1515686 - Set multiselected tabs to have the same design spec as active tabs wih a translucent colour (current text colour at 0.2 alpha) on top. r?jaws,dao

first push

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2890d7b4659
Set multiselected tabs to have the same design spec as active tabs wih a translucent colour (current text colour at 0.2 alpha) on top. r=jaws,dao

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/e2890d7b4659