Closed
Bug 1515686
Opened 6 years ago
Closed 6 years ago
Update multi-selected tab colour so it's more visible in default theme
Categories
(Firefox :: Tabbed Browser, defect, P3)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox 67
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: amylee, Assigned: ablayelyfondou)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
Update multi-selected tab colour so it's more visible in default theme. I've attached a spec for reference. Thanks.
Updated•6 years ago
|
Comment 1•6 years ago
|
||
Hi Amy,
The spec is a little confusing to me.
1. By "overlay" are you referring to the "tab-line"? This appears at the top of the tab and in your spec is blue.
2. For the background-color, you've proposed a solid color. We currently use a translucent color (#fff at .1 alpha) on top of the tab. This allows the themed color of the tab show through. If we move to a solid color, there is potential that we will conflict with a theme that has a similar solid color for the selected tab. I would prefer if we can keep a translucent color here.
Can you also please provide colors for background tabs that are showing black text in addition to the white text in the attached spec?
Thanks!
Flags: needinfo?(jaws) → needinfo?(amlee)
Reporter | ||
Comment 2•6 years ago
|
||
(In reply to (away Dec 24-26, Dec 31-Jan 1) Jared Wein [:jaws] (Regression Engineering Owner for 65) (please needinfo? me) from comment #1)
>
> 1. By "overlay" are you referring to the "tab-line"? This appears at the top
> of the tab and in your spec is blue.
No, I was referring to the translucent colour on top of the tab which you already explained is #fff .1 alpha.
> 2. For the background-color, you've proposed a solid color. We currently use
> a translucent color (#fff at .1 alpha) on top of the tab. This allows the
> themed color of the tab show through. If we move to a solid color, there is
> potential that we will conflict with a theme that has a similar solid color
> for the selected tab. I would prefer if we can keep a translucent color here.
Thanks for clarifying that the tab colour is inherited from a theme. What I am proposing is that multi-selected tabs inherit the focused tab colour instead of the unfocused tab colour and we have a translucent colour (#000000 at .1 alpha) on top.
Let me know if you see any issues with this.
> Can you also please provide colors for background tabs that are showing
> black text in addition to the white text in the attached spec?
I haven't modified anything else except for the above request.
> Thanks!
Hi Jared,
Flags: needinfo?(amlee)
Assignee | ||
Comment 3•6 years ago
|
||
Hi, maybe I could help here when the spec is validated.
Flags: needinfo?(jaws)
Comment 4•6 years ago
|
||
Does comment #2 clarify enough? This should be actionable now.
Flags: needinfo?(jaws) → needinfo?(ablayelyfondou)
Updated•6 years ago
|
Assignee: nobody → ablayelyfondou
Status: NEW → ASSIGNED
Assignee | ||
Comment 6•6 years ago
|
||
first push
Updated•6 years ago
|
Attachment #9035448 -
Attachment description: Bug 1515686 - Set multiselected tabs to have the same design spec as active tabs wih a
transluent colour ((#000000 at .1 alpha) on top. r?jaws → Bug 1515686 - Set multiselected tabs to have the same design spec as active tabs wih a translucent colour ((#000000 at .1 alpha) on top. r?jaws
Updated•6 years ago
|
Attachment #9035448 -
Attachment description: Bug 1515686 - Set multiselected tabs to have the same design spec as active tabs wih a translucent colour ((#000000 at .1 alpha) on top. r?jaws → Bug 1515686 - Set multiselected tabs to have the same design spec as active tabs wih a translucent colour (#000 for dark text and #fff for bright text, at 0.2 alpha) on top. r?jaws
Updated•6 years ago
|
Attachment #9035448 -
Attachment description: Bug 1515686 - Set multiselected tabs to have the same design spec as active tabs wih a translucent colour (#000 for dark text and #fff for bright text, at 0.2 alpha) on top. r?jaws → Bug 1515686 - Set multiselected tabs to have the same design spec as active tabs wih a translucent colour (current text colour at 0.2 alpha) on top. r?jaws
Updated•6 years ago
|
Attachment #9035448 -
Attachment description: Bug 1515686 - Set multiselected tabs to have the same design spec as active tabs wih a translucent colour (current text colour at 0.2 alpha) on top. r?jaws → Bug 1515686 - Set multiselected tabs to have the same design spec as active tabs wih a translucent colour (current text colour at 0.2 alpha) on top. r?jaws,dao
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e2890d7b4659
Set multiselected tabs to have the same design spec as active tabs wih a translucent colour (current text colour at 0.2 alpha) on top. r=jaws,dao
Comment 8•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in
before you can comment on or make changes to this bug.
Description
•