1515789 - onLoadRequest is fired multiple times for a single page load

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[Randall Barker [:rbarker]]

GeckoSession.NavigationDelegate.onLoadRequest() is called multiple time for a single page request. It isn't clear what is triggering the multiple calls. As an example, when loading codepen.io there are three onLoadRequests() calls made:

12-21 06:11:21.631  8852  8852 D VRB     : onLoadRequest: http://codepen.io/
...
12-21 06:14:21.186  8852  8852 D VRB     : onLoadRequest: https://i2.wp.com/static.codepen.io/assets/avatars/user-avatar-80x80-bdcd44a3bfb9a5fd01eb8b86f9e033fa1a9897c3a15b33adfc2649a002dab1b6.png?ssl=1
12-21 06:14:21.194  8852  8852 D VRB     : onLoadRequest: https://i2.wp.com/static.codepen.io/assets/avatars/user-avatar-80x80-bdcd44a3bfb9a5fd01eb8b86f9e033fa1a9897c3a15b33adfc2649a002dab1b6.png?ssl=1

Comment 1

[Chris Peterson [:cpeterson]]

Is this a regression? Does this happen for every page load?

Comment 2

[Randall Barker [:rbarker]]

Only certain pages seem to trigger this. I haven't had time to investigate what conditions cause multiple onLoadRequest to be called. It broke FxR user agent override because the subsequent calls to onLoadRequest were often not in the UA override list and was thus disabling it.

Comment 5

[Chris Peterson [:cpeterson]]

P1 because this bug affects PWAs and home screen shortcuts, a use case that we'd like to promote in Fenix.

Comment 6

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1515789 - Ensure nsILoadURIDelegate::loadURI() is only called for toplevel redirects. r?smaug

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6cf4cace2387
Ensure nsILoadURIDelegate::loadURI() is only called for toplevel redirects. r=smaug,geckoview-reviewers,esawin

Comment 8

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/6cf4cace2387