1515833 - 280,000 instances of "NS_ENSURE_SUCCESS(mStatus, mStatus) failed with result 0x804B000A" and related warnings during linux64 debug testing

Status: RESOLVED FIXED

(Firefox :: Protections UI, defect, P1)

Description

[Eric Rahm [:erahm]]

> 69936 WARNING: NS_ENSURE_SUCCESS(mStatus, mStatus) failed with result 0x804B000A: file obj-firefox/dist/include/nsIURIMutator.h, line 644

This warning [1] shows up in the following test suites:

>   4497 - test-linux64/debug-reftest-e10s-3 R3
>   4497 - test-linux64/debug-reftest-no-accel-e10s-3 Ru3
>   4495 - test-linux64/debug-reftest-no-accel-sw-e10s-3 Ru3
>   4493 - test-linux64/debug-reftest-sw-e10s-3 R3
>   3940 - test-linux64/debug-reftest-e10s-2 R2
>   3940 - test-linux64/debug-reftest-no-accel-e10s-2 Ru2
>   3940 - test-linux64/debug-reftest-no-accel-sw-e10s-2 Ru2
>   3940 - test-linux64/debug-reftest-sw-e10s-2 R2
>   2737 - test-linux64/debug-reftest-sw-e10s-1 R1
>   2737 - test-linux64/debug-reftest-e10s-1 R1
>   2732 - test-linux64/debug-reftest-no-accel-e10s-1 Ru1
>   2732 - test-linux64/debug-reftest-no-accel-sw-e10s-1 Ru1
>   1431 - test-linux64/debug-reftest-no-accel-sw-e10s-4 Ru4
>   1431 - test-linux64/debug-reftest-no-accel-e10s-4 Ru4
>   1431 - test-linux64/debug-reftest-sw-e10s-4 R4
>   1431 - test-linux64/debug-reftest-e10s-4 R4
>   1096 - test-linux64/debug-reftest-e10s-8 R8
>   1096 - test-linux64/debug-reftest-sw-e10s-8 R8
>   1092 - test-linux64/debug-reftest-no-accel-e10s-8 Ru8
>   1091 - test-linux64/debug-reftest-no-accel-sw-e10s-8 Ru8
>   1044 - test-linux64/debug-reftest-e10s-5 R5
>   1044 - test-linux64/debug-reftest-sw-e10s-5 R5
>   1044 - test-linux64/debug-reftest-no-accel-sw-e10s-5 Ru5
>   1044 - test-linux64/debug-reftest-no-accel-e10s-5 Ru5
>   1040 - test-linux64/debug-reftest-e10s-7 R7
>   1040 - test-linux64/debug-reftest-no-accel-sw-e10s-7 Ru7
>   1040 - test-linux64/debug-reftest-sw-e10s-7 R7
>   1040 - test-linux64/debug-reftest-no-accel-e10s-7 Ru7
>    768 - test-linux64/debug-crashtest-e10s C
>    762 - test-linux64/debug-crashtest-sw-e10s C
>    717 - test-linux64/debug-reftest-no-accel-e10s-6 Ru6
>    717 - test-linux64/debug-reftest-no-accel-sw-e10s-6 Ru6
>    712 - test-linux64/debug-reftest-e10s-6 R6
>    712 - test-linux64/debug-reftest-sw-e10s-6 R6
>    661 - test-linux64/debug-web-platform-tests-sw-e10s-5 wpt5
>    661 - test-linux64/debug-web-platform-tests-e10s-5 wpt5
>    178 - test-linux64/debug-mochitest-browser-chrome-e10s-6 bc6
>    178 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-5 bc5
>     49 - test-linux64/debug-mochitest-browser-chrome-e10s-7 bc7
>     44 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-11 bc11
>     44 - test-linux64/debug-mochitest-browser-chrome-e10s-13 bc13
>     44 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-13 bc13
>     37 - test-linux64/debug-mochitest-browser-chrome-e10s-5 bc5
>     29 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-7 bc7
>     16 - test-linux64/debug-mochitest-plain-headless-sw-e10s-5 h5
>     16 - test-linux64/debug-mochitest-sw-e10s-5 5
>     16 - test-linux64/debug-mochitest-browser-chrome-e10s-2 bc2
>     16 - test-linux64/debug-web-platform-tests-sw-e10s-18 wpt18
>     16 - test-linux64/debug-web-platform-tests-e10s-18 wpt18
>     16 - test-linux64/debug-mochitest-e10s-5 5
>     16 - test-linux64/debug-mochitest-plain-headless-e10s-5 h5
>     15 - test-linux64/debug-mochitest-chrome-sw-2 c2
>     15 - test-linux64/debug-web-platform-tests-e10s-2 wpt2
>     15 - test-linux64/debug-web-platform-tests-sw-e10s-2 wpt2
>     15 - test-linux64/debug-mochitest-chrome-2 c2
>     13 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-1 dt1
>     13 - test-linux64/debug-mochitest-devtools-chrome-e10s-5 dt5
>     13 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-9 bc9
>     12 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-1 bc1
>     11 - test-linux64/debug-mochitest-browser-chrome-e10s-3 bc3
>     11 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-2 bc2
>      9 - test-linux64/debug-mochitest-e10s-9 9
>      9 - test-linux64/debug-mochitest-browser-chrome-e10s-11 bc11
>      9 - test-linux64/debug-marionette-headless-e10s MnH
>      9 - test-linux64/debug-mochitest-plain-headless-e10s-9 h9
>      9 - test-linux64/debug-mochitest-sw-e10s-9 9
>      9 - test-linux64/debug-marionette-e10s Mn
>      9 - test-linux64/debug-mochitest-plain-headless-sw-e10s-9 h9
>      8 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-4 bc4
>      7 - test-linux64/debug-mochitest-sw-e10s-10 10
>      7 - test-linux64/debug-mochitest-e10s-10 10
>      7 - test-linux64/debug-mochitest-plain-headless-sw-e10s-10 h10
>      7 - test-linux64/debug-mochitest-plain-headless-e10s-10 h10
>      6 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-10 bc10
>      6 - test-linux64/debug-web-platform-tests-sw-e10s-17 wpt17
>      6 - test-linux64/debug-web-platform-tests-e10s-14 wpt14
>      6 - test-linux64/debug-web-platform-tests-e10s-17 wpt17
>      6 - test-linux64/debug-web-platform-tests-sw-e10s-14 wpt14
>      5 - test-linux64/debug-mochitest-clipboard-sw-e10s cl
>      5 - test-linux64/debug-web-platform-tests-wdspec-e10s-1 Wd1
>      5 - test-linux64/debug-web-platform-tests-wdspec-sw-e10s-1 Wd1
>      5 - test-linux64/debug-mochitest-clipboard-e10s cl
>      4 - test-linux64/debug-web-platform-tests-e10s-8 wpt8
>      4 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-3 bc3
>      4 - test-linux64/debug-mochitest-devtools-chrome-e10s-2 dt2
>      4 - test-linux64/debug-web-platform-tests-sw-e10s-8 wpt8
>      4 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-5 dt5
>      4 - test-linux64/debug-mochitest-browser-chrome-e10s-9 bc9
>      3 - test-linux64/debug-mochitest-e10s-11 11
>      3 - test-linux64/debug-web-platform-tests-sw-e10s-3 wpt3
>      3 - test-linux64/debug-mochitest-plain-headless-sw-e10s-11 h11
>      3 - test-linux64/debug-mochitest-chrome-sw-3 c3
>      3 - test-linux64/debug-mochitest-sw-e10s-11 11
>      3 - test-linux64/debug-web-platform-tests-sw-e10s-13 wpt13
>      3 - test-linux64/debug-mochitest-chrome-3 c3
>      3 - test-linux64/debug-mochitest-plain-headless-e10s-11 h11
>      3 - test-linux64/debug-web-platform-tests-e10s-13 wpt13
>      3 - test-linux64/debug-web-platform-tests-e10s-3 wpt3
>      2 - test-linux64/debug-mochitest-e10s-8 8
>      2 - test-linux64/debug-mochitest-plain-headless-sw-e10s-14 h14
>      2 - test-linux64/debug-web-platform-tests-sw-e10s-7 wpt7
>      2 - test-linux64/debug-web-platform-tests-e10s-7 wpt7
>      2 - test-linux64/debug-mochitest-sw-e10s-14 14
>      2 - test-linux64/debug-mochitest-plain-headless-e10s-7 h7
>      2 - test-linux64/debug-mochitest-e10s-7 7
>      2 - test-linux64/debug-mochitest-plain-headless-sw-e10s-8 h8
>      2 - test-linux64/debug-mochitest-devtools-chrome-e10s-4 dt4
>      2 - test-linux64/debug-mochitest-plain-headless-e10s-8 h8
>      2 - test-linux64/debug-mochitest-e10s-14 14
>      2 - test-linux64/debug-mochitest-sw-e10s-7 7
>      2 - test-linux64/debug-web-platform-tests-sw-e10s-11 wpt11
>      2 - test-linux64/debug-web-platform-tests-sw-e10s-9 wpt9
>      2 - test-linux64/debug-mochitest-plain-headless-e10s-14 h14
>      2 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-4 dt4
>      2 - test-linux64/debug-mochitest-sw-e10s-8 8
>      2 - test-linux64/debug-web-platform-tests-e10s-9 wpt9
>      2 - test-linux64/debug-web-platform-tests-e10s-11 wpt11
>      2 - test-linux64/debug-mochitest-plain-headless-sw-e10s-7 h7
>      1 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-15 bc15
>      1 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-16 bc16
>      1 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-6 bc6
>      1 - test-linux64/debug-mochitest-browser-chrome-e10s-16 bc16
>      1 - test-linux64/debug-gtest GTest
>      1 - test-linux64/debug-firefox-ui-functional-local-e10s en-US
>      1 - test-linux64/debug-web-platform-tests-sw-e10s-15 wpt15
>      1 - test-linux64/debug-web-platform-tests-sw-e10s-12 wpt12
>      1 - test-linux64/debug-web-platform-tests-e10s-6 wpt6
>      1 - test-linux64/debug-mochitest-browser-chrome-e10s-8 bc8
>      1 - test-linux64/debug-web-platform-tests-sw-e10s-16 wpt16
>      1 - test-linux64/debug-web-platform-tests-sw-e10s-6 wpt6
>      1 - test-linux64/debug-web-platform-tests-e10s-16 wpt16
>      1 - test-linux64/debug-web-platform-tests-sw-e10s-4 wpt4
>      1 - test-linux64/debug-mochitest-browser-chrome-e10s-15 bc15
>      1 - test-linux64/debug-web-platform-tests-e10s-4 wpt4
>      1 - test-linux64/debug-web-platform-tests-e10s-12 wpt12
>      1 - test-linux64/debug-mochitest-devtools-chrome-e10s-7 dt7
>      1 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-7 dt7
>      1 - test-linux64/debug-web-platform-tests-e10s-15 wpt15

It shows up in 3040 tests. A few of the most prevalent:

>   2064 - [e10s] file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/box-properties/abspos-replaced-width-offset-margin.html == file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/box-properties/abspos-replaced-width-offset-margin-ref.html
>    624 - [e10s] file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/css-grid/grid-item-intrinsic-ratio-normal-003.html == file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/css-grid/grid-item-intrinsic-ratio-normal-003-ref.html
>    576 - [e10s] file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/css-grid/grid-item-intrinsic-ratio-normal-001.html == file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/css-grid/grid-item-intrinsic-ratio-normal-001-ref.html
>    576 - [e10s] file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/css-grid/grid-item-intrinsic-ratio-normal-002.html == file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/css-grid/grid-item-intrinsic-ratio-normal-002-ref.html
>    524 - [e10s] file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/css-grid/grid-item-auto-min-size-clamp-003.html == file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/css-grid/grid-item-auto-min-size-clamp-003-ref.html
>    500 - [e10s] file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/bugs/456219-1a.html == file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/bugs/456219-1-ref.html
>    452 - [e10s] file:///builds/worker/workspace/build/tests/reftest/tests/layout/xul/reftest/image-size.xul == file:///builds/worker/workspace/build/tests/reftest/tests/layout/xul/reftest/image-size-ref.xul
>    426 - [e10s] file:///builds/worker/workspace/build/tests/reftest/tests/layout/generic/crashtests/947158.html
>    396 - [e10s] file:///builds/worker/workspace/build/tests/reftest/tests/dom/workers/test/crashtests/1228456.html
>    356 - [e10s] browser/base/content/test/siteIdentity/browser_check_identity_state.js

[1] https://hg.mozilla.org/mozilla-central/annotate/49be2c1eb4c8/obj-firefox/dist/include/nsIURIMutator.h#l644

Comment 1

[Eric Rahm [:erahm]]

There's a cluster of these that seem to be related:

> 69936 WARNING: NS_ENSURE_SUCCESS(mStatus, mStatus) failed with result 0x804B000A: file obj-firefox/dist/include/nsIURIMutator.h, line 644
> 69194 WARNING: NS_ENSURE_SUCCESS(mStatus, *this) failed with result 0x804B000A: file obj-firefox/dist/include/nsIURIMutator.h, line 605
> 69194 WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x804B000A: file obj-firefox/dist/include/nsIURIMutator.h, line 450
> 67863 WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x804B000A: file toolkit/components/antitracking/AntiTrackingCommon.cpp, line 1362

Bisection points to: 

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1ba2376aa7fcec04e0c240d4512700ea0bfd68b7&tochange=156f9442db847c065c50af78968226369f47c151

Ehsan, I'm 99% sure this is related to the network.cookie.cookieBehavior change in bug 1492563.

Comment 2

[Eric Rahm [:erahm]]

Attachment: Remove verbose nsIURIMutator warnings

Ehsan, this just silences the warnings. Given the verbosity this seems like the right thing to do, but if you want to investigate further feel free to redirect this bug to the right person.

Comment 3

[(no longer active)]

Comment on attachment 9033003 [details] [diff] [review]
Remove verbose nsIURIMutator warnings

Review of attachment 9033003 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/antitracking/AntiTrackingCommon.cpp
@@ +1359,4 @@
>    // Stuff the whole thing back into a URI for the permission manager.
>    nsCOMPtr<nsIURI> topWinURI;
>    rv = ios->NewURI(escaped, nullptr, nullptr, getter_AddRefs(topWinURI));
> +  if (NS_FAILED(rv)) return rv;

r+ on this part, the rest is up to someone from the Necko team, I can't spend time to dig into it right now unfortunately.

I meant to pick Valentin but he isn't currently accepting review requests.  Please ask for review from a Necko peer when you return from PTO?

Comment 4

[Eric Rahm [:erahm]]

Comment on attachment 9033003 [details] [diff] [review]
Remove verbose nsIURIMutator warnings

Review of attachment 9033003 [details] [diff] [review]:
-----------------------------------------------------------------

Honza can you take a look at the idl changes?

Comment 5

[Honza Bambas (:mayhemer)]

Comment on attachment 9033003 [details] [diff] [review]
Remove verbose nsIURIMutator warnings

Review of attachment 9033003 [details] [diff] [review]:
-----------------------------------------------------------------

OK, but now we don't know which function in the chaining has failed.  Do you know on what URL and what method call this happens?

I'd also be curious if this a bug or not (to fail, not to log)

Comment 6

[Honza Bambas (:mayhemer)]

Adding Valentin (maybe even let him review?)

Comment 7

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 9033003 [details] [diff] [review]
Remove verbose nsIURIMutator warnings

Review of attachment 9033003 [details] [diff] [review]:
-----------------------------------------------------------------

This is fine. We get this whenever there's an invalid URI operation we're performing. It would have been nicer if I had made it more explicit :).
In any case, especially in WPT tests for URLs, it will definitely show up a lot in the logs, so we probably don't want it.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a05c9040d245
Remove verbose nsIURIMutator warnings. r=ehsan, valentin

Comment 9

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/a05c9040d245