Closed
Bug 1515841
Opened 7 years ago
Closed 7 years ago
tc-lib-api still has res.reportInternalError calls in it..
Categories
(Taskcluster :: Services, enhancement)
Taskcluster
Services
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dustin, Assigned: dustin)
Details
These need to be removed.
|
Assignee | |
Comment 1•7 years ago
|
||
|
||
Updated•7 years ago
|
Assignee: dustin → arshadkazmi42
Status: NEW → ASSIGNED
|
|
||
Comment 2•7 years ago
|
||
|
|
Assignee | |
Comment 3•7 years ago
|
||
I need to add some tests to this to make sure the fix works.
Assignee: arshadkazmi42 → dustin
|
|
Assignee | |
Comment 4•7 years ago
|
||
OK, tests improved (they were checking for 500 ISE, but not looking at the contents, and not checking that monitor.reportError had been called)
|
||
Comment 5•7 years ago
|
||
Commits pushed to master at https://github.com/taskcluster/taskcluster-lib-api
https://github.com/taskcluster/taskcluster-lib-api/commit/22221e4d607cd2b2ec7062835145842d4916b1a5
Bug 1515841 - remove remaining uses of reportInternalError
https://github.com/taskcluster/taskcluster-lib-api/commit/23ca3a45fce05d5e419666a4c29673beb69cc1e3
Bug 1515841 - better tests for schema errors
|
|
Assignee | |
Updated•7 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Component: Platform Libraries → Services
You need to log in
before you can comment on or make changes to this bug.
Description
•