Closed
Bug 1515901
Opened 6 years ago
Closed 6 years ago
mozconfig is loaded multiple times when running mach help, making it extra slow on Windows
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox66 fixed)
RESOLVED
FIXED
mozilla66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•6 years ago
|
||
When running `mach help`, mozconfig is loaded multiple times, and even
with an almost empty mozconfig, this makes mach help take close to 10
seconds on my Windows machine.
With some memoization, the time to run mach help gets down to 2s.
|
||
Comment 2•6 years ago
|
||
Backed out changeset e8700e52f777 (bug 1515901) for build bustage. CLOSED TREE
Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=218417584&repo=autoland&lineNumber=5294
Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=e8700e52f777b56af2c095d545fd084478bd9db5
Backout:
https://hg.mozilla.org/integration/autoland/rev/7d919c848dc8055ee83953b1f851180e364d954b
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/7212af915b68
Avoid loading mozconfig multiple times from MozbuildObject. r=froydnj
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•