Closed
Bug 1515954
Opened 6 years ago
Closed 6 years ago
Isolate favicon url matching logic and add test cases
Categories
(Firefox for iOS :: Favicons, enhancement)
Tracking
()
RESOLVED
INVALID
| Tracking | Status | |
|---|---|---|
| fxios | ? | --- |
People
(Reporter: garvan, Unassigned)
Details
The favicon URL matching logic should be pulled out into a testable function, and a unit test could be verifying the different cases of website URLs and their expected matching favicon domain/normalized domain/full url.
Is only a few lines of code, but worthy of a test case I think.
|
||
Comment 1•6 years ago
|
||
tests are here
https://github.com/mozilla-mobile/firefox-ios/blob/master/Client/Extensions/UIImageViewExtensions.swift
and
https://github.com/mozilla-mobile/firefox-ios/blob/master/ClientTests/TestFavicons.swift#L51
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•