Closed Bug 1516180 Opened 4 years ago Closed 3 years ago

Port Bug 1469916 to SeaMonkey

Categories

(SeaMonkey :: Security, defect)

defect
Not set
normal

Tracking

(seamonkey2.63 fixed, seamonkey2.57esr unaffected)

RESOLVED FIXED
SeaMonkey2.63
Tracking Status
seamonkey2.63 --- fixed
seamonkey2.57esr --- unaffected

People

(Reporter: frg, Assigned: frg)

Details

Attachments

(1 file, 1 obsolete file)

Bug 1469916 has not been backported to ESR60 so comm-central only.

https://hg.mozilla.org/mozilla-central/rev/9a2b02fe351b

Bill reported it to me. We have a broken macOS compile:

> 98:49.66 /home/wag/mozilla/seamonkey/mozilla/comm/suite/components/shell/nsMacShellService.cpp:179:51: error: too few arguments to function call, expected 9, have 8
> 98:49.66 mBackgroundFile, loadContext);
Attached patch 1516180-port.patch (obsolete) — Splinter Review
I am not sure I got everything (right). Only the saveURL calls without a document need the principal.
Attachment #9033119 - Flags: review?(iann_bugzilla)
drat typo time.
Attachment #9033119 - Attachment is obsolete: true
Attachment #9033119 - Flags: review?(iann_bugzilla)
Attachment #9033120 - Flags: review?(iann_bugzilla)
Comment on attachment 9033120 [details] [diff] [review]
1516180-port.patch

r=me
Attachment #9033120 - Flags: review?(iann_bugzilla) → review+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/4b28c50a8eea
Provide principal when saving content. r=IanN
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → SeaMonkey2.63
Version: SeaMonkey 2.60 Branch → Trunk
You need to log in before you can comment on or make changes to this bug.