1516269 - about:policies: the background-color transition on hover flickers

Status: VERIFIED FIXED

(Firefox :: Enterprise Policies, enhancement, P3)

Description

[:Felipe Gomes (needinfo for replies!)]

The transition effect that can be seen in the Documentation tab when moving the mouse over each row is flickering.

I investigated and the problem is that both the transition and the :hover background-color are on the <td>, whereas the original even/odd background-color are on the <tr>. So the transition doesn't know from which color to start, and then it picks white.

To fix this we should put everything on the <tr>.


Another related problem is that the :hover effect is not properly working in the Active tab. It only works on the even rows, and with no transition. We should probably fix both together

Comment 1

[Sören Hentzschel]

Hi,

I have a patch to fix this. Unfortunately these changes landed in another Phabricator request (where I already reverted the unrelated change).

Can you explain me how to work on more than one ticket at the same time? I used "hg add <directory>", "hg commit -m 'commit message' <directory>", "arc diff" but instead of a new Phabricator request my changes landed as new diff in my previous Phabricator request.

Thank you.

Comment 2

[Sören Hentzschel]

Attachment: Bug 1516269 - fixed the hover state for the rows in about:policies

Comment 3

[:Felipe Gomes (needinfo for replies!)]

(In reply to Sören Hentzschel from comment #1)
> Hi,
> 
> I have a patch to fix this. Unfortunately these changes landed in another
> Phabricator request (where I already reverted the unrelated change).
> 
> Can you explain me how to work on more than one ticket at the same time? I
> used "hg add <directory>", "hg commit -m 'commit message' <directory>", "arc
> diff" but instead of a new Phabricator request my changes landed as new diff
> in my previous Phabricator request.
> 
> Thank you.

Hi! I saw that you e-mail'ed dev-platform and that's probably a good idea as i'm not a big expert on Phabricator either. I'd just like to add that I think part of the problem might be because, as far as know, `arc` doesn't officially support this. That's why mozilla is writing the `moz-phab` tool which is a wrapper around arc to make it work. There's also an alternative tool called `hg phabsend` that some people (including myself) is using.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27a4dfa5c033
fixed the hover state for the rows  in about:policies r=Felipe

Comment 5

[Sören Hentzschel]

Thank you, Felipe! I'm going to look for other small tasks and try moz-phab and/or hg phabsend. :)

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/27a4dfa5c033

Comment 7

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 66.0a1 (2018-12-24) on Windows 10, 64 Bit! This bug's fix is verified with latest Nightly 66.0a1!

Build ID : 20190114014511
User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:66.0) Gecko/20100101 Firefox/66.0

Comment 8

[Camelia Badau [:cbadau], Desktop QA]

Marking VERIFIED FIXED based on previous comment.