1516275 - responsive design mode doesn't close

Status: REOPENED

(DevTools :: Responsive Design Mode, defect, P3)

Description

[clem_pro]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0

Steps to reproduce:

- open Responsive Design mode (Ctrl + Shift + M or menu Developpement web > Vue adaptative)
- click on the close button (top right menu bar) or Ctrl + Shift + M


Actual results:

 nothing is happening


Expected results:

closing Responsive Design mode (return to normal mode)

Comment 1

[Razvan Caliman [:rcaliman]]

Attachment: RDM tooltip close .mp4

Thanks for filing!

This seems to happen because of the "new feature" tooltip. On first click, the tooltip frame seems to capture the click. After closing the tooltip, the next click closes the responsive design mode as expected. Once the tooltip is dismissed, this issue doesn't occur. See video.

This occurs in Firefox Stable (64) and Developer Edition (65), but not on Nightly (66) because the tooltip is set to not show up anymore. 

To replicate in Firefox 64 and 65, go to about:config and reset this pref: 
devtools.responsive.show-setting-tooltip

Comment 2

[Razvan Caliman [:rcaliman]]

@clem_pro, can you please confirm that the root cause is indeed the one explained in the comment above?

If you no longer see the tooltip, please navigate to about:config, search for devtools.responsive.show-setting-tooltip, right click and select "Reset" to get it back next time you open RDM.

Comment 3

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1516275 - Allow users to close RDM on first click even when tooltip is visible; r=jdescottes

Setup RDM tooltip to not consume clicks and allow users to interact with the RDM on first try. The behavior of consuming clicks led at least one user to believe RDM could not be closed and filed a bug. Likely others encountered the same (small) road block when trying other actions.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ded030d641a2
Allow users to close RDM on first click even when tooltip is visible; r=jdescottes

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ded030d641a2

Comment 6

[Razvan Caliman [:rcaliman]]

Comment on attachment 9035019 [details]
Bug 1516275 - Allow users to close RDM on first click even when tooltip is visible; r=jdescottes

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1467572

User impact if declined: Users who see the "new feature" tool tip cannot immediately interact with the Responsive Design Mode (RDM) because the tooltip frame will consume their first click, regardless of where this click happens. This confuses people leading some to believe the tool is broken/unresponsive. It's a small road block. The next click is followed through. Until users explicitly close the tooltip, this issue happens over and over again for the first click on the RDM interface.

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce:

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Not risky. The patch just allows the first user click to go through as it would normally do if the tooltip were not visible.

String changes made/needed: None

Comment 7

[clem_pro]

(In reply to Razvan Caliman [:rcaliman] from comment #2)

@clem_pro, can you please confirm that the root cause is indeed the one
explained in the comment above?

no, I do not confirm that the problem is related to the appearance of the tooltip: the bug appears while I have NOT the tooltip displayed.
By the way I am now in version 64.0.2 and I still have the problem whatever the value of the option devtools.responsive.show-setting-tooltip (true or false)

Thanks for your help!

Comment 8

[Razvan Caliman [:rcaliman]]

(In reply to clem_pro from comment #7)

(In reply to Razvan Caliman [:rcaliman] from comment #2)
By the way I am now in version 64.0.2 and I still have the problem whatever the value of the option devtools.responsive.show-setting-tooltip (true or false)

Thanks for the information. Can you please share a quick video of the problem in action so we can try to spot if there's anything else causing this for you.

The tooltip catching the first click is still a valid reason why the RDM didn't close on first try, but it sounds like there's more to this issue that I can't replicate. Please help us find out.

Comment 9

[clem_pro]

If it can help, you can download the quick capture on http://galactron.org/IMG/bugzilla/bug_firefox_adaptative_1516275.mp4

Thanks for all

Comment 10

[Patrick Brosset <:pbro>]

Thanks for video clem_pro. I tested on Windows with Firefox 60, 64 and 66 but couldn't reproduce the issue on any of these versions.
I'm starting to think that maybe this has something to do with an extension? That could happen.
Sorry to be asking more of your time, but if you have some, could you please try these 2 things:

• after the problem occurs, please open the browser console (ctrl+shift+J) and see if there are errors in there. Big scary things in red usually :) If so, please paste them here.
• also, could you please try in safe mode to check if any addon is causing this issue: https://support.mozilla.org/en-US/kb/troubleshoot-firefox-issues-using-safe-mode

Thank you very much!

Comment 11

[clem_pro]

For the safe-mode: sorry not to have specified in the description of the bug but I had tried it from the beginning and it does not change the problem.

On the other hand, the console gives me 5 error messages when I open Responsive Mode (in safe-mode):

1. uncaught exception: 2147500033 browser.xml:1048:13
2. [Exception... "Method not implemented'Method not implemented' when calling method: [nsIWebNavigation::sessionHistory]" nsresult: "0x80004001 (NS_ERROR_NOT_IMPLEMENTED)" location: "JS frame :: chrome://global/content/bindings/browser.xml :: construct :: line 1048" data: no]
3. Quota Expected the third empty token!: ActorsParent.cpp:8665
4. Quota Origin 'file+++UNIVERSAL_FILE_URI_ORIGIN' failed to parse, handled tokens: 'file', '', '': ActorsParent.cpp:8461
   IndexedDB UnknownErr: ActorsParent.cpp:605
5. undefined
   (no details for the 5.)

When I try to close it (click on icon or CTRL + SHIFT + M) I have the following message (only the first time I try to close):

1. uncaught exception: undefined
   (no details)

I hope this could help...

Comment 12

[Razvan Caliman [:rcaliman]]

Comment on attachment 9035019 [details]
Bug 1516275 - Allow users to close RDM on first click even when tooltip is visible; r=jdescottes

@clem_pro, thank you for the extra information about the errors found in Safe Mode. We can't reproduce this, so it will require additional investigation by the team.

Removing the request to uplift the patch because the original issue is not fixed by it.

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

Happy to take a patch in nightly 67, or potentially, in beta 66 for this.
I'm marking it fix-optional to remove it from weekly regression triage, since it has a priority assigned.

Comment 14

[myself]

Can't close the RDM any longer in FF 68.0.1

I haven't found other bugreports regarding this topic so I comment on this one.