Closed
Bug 1516287
Opened 6 years ago
Closed 6 years ago
Today pane frequently fails to initialise
Categories
(Calendar :: Lightning Only, defect)
Calendar
Lightning Only
Tracking
(Not tracked)
RESOLVED
FIXED
6.7
People
(Reporter: darktrojan, Assigned: darktrojan)
Details
Attachments
(1 file)
|
1.68 KB,
patch
|
Fallen
:
review+
Fallen
:
approval-calendar-beta+
|
Details | Diff | Splinter Review |
Using Thunderbird 65 beta 1, I frequently get this error at start-up, and the Today Pane doesn't show:
> InvalidAccessError: A parameter or an operation is not supported by the underlying object calendar-views.js:466
This is the part that loads calendar colours into a stylesheet. I think it might be happening too early because the same code can run again later with no problem.
| Assignee | ||
Comment 1•6 years ago
|
||
I've used this pattern in the other two places we add rules to a stylesheet, but not this one, apparently.
Comment 2•6 years ago
|
||
Comment on attachment 9033257 [details] [diff] [review]
1516287-category-colour-1.diff
Review of attachment 9033257 [details] [diff] [review]:
-----------------------------------------------------------------
Would feel more comfortable if there was an if() that checks for a certain exception and re-raises if not, but I guess its ok without as well.
Attachment #9033257 -
Flags: review?(philipp) → review+
| Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/e8fcc4360ac4
Wait for stylesheet to load before adding category colours. r=philipp
| Assignee | ||
Updated•6 years ago
|
Attachment #9033257 -
Flags: approval-calendar-beta?(philipp)
Updated•6 years ago
|
Target Milestone: --- → 6.8
Updated•6 years ago
|
Attachment #9033257 -
Flags: approval-calendar-beta?(philipp) → approval-calendar-beta+
Comment 4•6 years ago
|
||
TB 65 beta 2, Cal 6.7:
https://hg.mozilla.org/releases/comm-beta/rev/8b4c9d319ddbade1ba70963fe7acb8416dccd99e
Target Milestone: 6.8 → 6.7
You need to log in
before you can comment on or make changes to this bug.
Description
•