151648 - 'QA Contact' column presented with useqacontact = Off

Status: RESOLVED FIXED

(Bugzilla :: User Accounts, defect)

Description

[Mats Palmgren (inactive)]

OVERVIEW:
In our local installation of Bugzilla 2.17 (updated today from CVS) we are not
using the QA field. So we have useqacontact = Off.

ACTUAL BEHAVIOUR:
User email prefs still presents a 'QA Contact' column.

EXPECTED BEHAVIOUR:
No 'QA Contact' column.

Comment 1

[Bradley Baetz (:bbaetz)]

-> gerv

Comment 2

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Indeed, you are right. Good catch. This should fix it.

Gerv

Comment 3

[Jouni Heikniemi]

Comment on attachment 87651 [details] [diff] [review]
Patch v.1

>-    <td colspan="5" align="center" width="50%">
>+    <td colspan="[% useqacontact ? '5' : '4' %]" align="center" width="50%">
>       <b>When my relationship to this bug is:</b>
>     </td>
>     <td rowspan="2" width="50%">

The patch works, but you need to make td widths in this part adapt to the
useqacontact changes. Specifically, the first td should have a 40% width when
!useqacontact, and in that case the latter td should have 60%.

Comment 4

[Gervase Markham [:gerv]]

Jouni: does it really matter? I didn't see any layout problems when I tried it.
It just seems to me like it complicates the template to make the two versions
look more similar, when no-one will actually care.

Gerv

Comment 5

[Gervase Markham [:gerv]]

Can someone review this? myk - you may well want it on b.m.o.

Gerv

Comment 6

[Jouni Heikniemi]

Comment on attachment 87651 [details] [diff] [review]
Patch v.1

Oh all right. Maybe the td widths are not that important. Per my previous
tests, 2xr=jouni.

Comment 7

[Gervase Markham [:gerv]]

Fixed.

Checking in template/en/default/account/prefs/email.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/prefs/email.html.tmpl,v
 <--  email.html.tmpl
new revision: 1.1.2.3; previous revision: 1.1.2.2
done

Checking in template/en/default/account/prefs/email.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/prefs/email.html.tmpl,v
 <--  email.html.tmpl
new revision: 1.5; previous revision: 1.4
done

Gerv