1516577 - Update GeckoView about:config visual design

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, enhancement, P5)

Description

[csheany]

User Agent: Mozilla/5.0 (Android 7.1.1; Tablet; rv:66.0) Gecko/66.0 Firefox/66.0

Steps to reproduce:

1. Open about:config


Actual results:

It is based on Australis?


Expected results:

It should match desktop

Comment 2

[Jan Henning [:JanH]]

Mobile uses its own about:config implementation, so do you want to replace that as well, or was this just a mistake?

Comment 3

[:Paolo Amadini]

Mistake - somebody added this among others in bug 1493439 comment 2 and I didn't notice it was for a different component.

Comment 4

[csheany]

FWIW, this was filed in regard to a fresh coat of paint as it looks dated against the toolbar.

Comment 5

[csheany]

I realize it is developer oriented but if Fenix uses the same page it might be nice have a slightly higher priority given the design overhaul.

Comment 7

[Tim Nguyen :ntim]

Attachment: Bug 1516577 - Update GeckoView about:config visual design.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e1f3312247a
Update GeckoView about:config visual design. r=geckoview-reviewers,snorp

Comment 9

[Tim Nguyen :ntim]

Attachment: Before/After

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/6e1f3312247a

Comment 12

[Diana Rus]

Hi, verified the issue with Sony Xperia Z5 (7.0), Samsung Galaxy S8+(Android 8.0.0),Google Pixel 3a (Android 9) and Google Pixel (Android 10) on Firefox Preview Nightly 200113 (Build #20130606 GV 74.0a1-20200110095023)
Light Theme:

• Sony Xperia Z5 Portrait Landscape
• Samsung Galaxy S8+ Portrait Landscape
• Google Pixel 3a (Android 9) Portrait Landscape

Dark Theme:

• Sony Xperia Z5 - the about:config page is as in the after photo from comment9 in both portrait and landscape mode
• Samsung galaxy S8+ - the about:config page is as in the after photo from comment9 in both portrait and landscape mode
• Google Pixel 3a - the about:config page is as in the after photo from comment9 in both portrait and landscape mode

Note:

• For RTL languages how should it be? At the moment when changing in a RTL language it remains the same(search bar and the "+" button that adds a new preference)?
  On fennec it seems that when the user changes to a RTL language the search bar and plus sign is correctly displayed.

Comment 13

[Tim Nguyen :ntim]

(In reply to Diana Rus from comment #12)

Hi, verified the issue with Sony Xperia Z5 (7.0), Samsung Galaxy S8+(Android 8.0.0),Google Pixel 3a (Android 9) and Google Pixel (Android 10) on Firefox Preview Nightly 200113 (Build #20130606 GV 74.0a1-20200110095023)
Light Theme:

• Sony Xperia Z5 Portrait Landscape
• Samsung Galaxy S8+ Portrait Landscape
• Google Pixel 3a (Android 9) Portrait Landscape

Dark Theme:

• Sony Xperia Z5 - the about:config page is as in the after photo from comment9 in both portrait and landscape mode
• Samsung galaxy S8+ - the about:config page is as in the after photo from comment9 in both portrait and landscape mode
• Google Pixel 3a - the about:config page is as in the after photo from comment9 in both portrait and landscape mode

Note:

• For RTL languages how should it be? At the moment when changing in a RTL language it remains the same(search bar and the "+" button that adds a new preference)?
  On fennec it seems that when the user changes to a RTL language the search bar and plus sign is correctly displayed.

The RTL problems will be handled in bug 1325230, thanks for testing!