1516701 - ARM64: Implement MacroAssembler::storeRegsInMask()

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement, P2)

Description

[Sean Stangl [:sstangl]]

Attachment: 0001-Implement-MacroAssembler-storeRegsInMask.patch

Passes a lot of tests; basic implementation mirroring other platforms. Nothing exciting.

Comment 1

[Nicolas B. Pierron [:nbp]]

Comment on attachment 9033584 [details] [diff] [review]
0001-Implement-MacroAssembler-storeRegsInMask.patch

Review of attachment 9033584 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/arm64/MacroAssembler-arm64.cpp
@@ +483,5 @@
> +  }
> +  MOZ_ASSERT(numFpu == 0);
> +  // Padding to keep the stack aligned, taken from the x64 and mips64 implementations.
> +  diffF -= diffF % sizeof(uintptr_t);
> +  MOZ_ASSERT(diffF == 0);

note: I suspect this assertion would trigger in the future with float32 test cases as FloatRegister::GetPushSizeInBytes [1] does not compute float32 storage space correctly, as opposed to x64 [2].

[1] https://searchfox.org/mozilla-central/source/js/src/jit/arm64/Architecture-arm64.cpp#59-61
[2] https://searchfox.org/mozilla-central/source/js/src/jit/x86-shared/Architecture-x86-shared.cpp#65-66,87

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fcf60924da90
Implement MacroAssembler::storeRegsInMask(). r=nbp

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/fcf60924da90