1516706 - privatebrowsing support for omnibox api

Status: VERIFIED FIXED

(WebExtensions :: General, enhancement, P1)

Comment 1

[Shane Caraveo (:mixedpuppy)]

I want to prevent the events being fired in ext-omnibox. I was investigating this, I see that we do not know what window any given search is initiated from. I was wondering if you have any ideas around this.

One thought I have is to just check the topmost window, seems that is likely the only place we'd get a omnibox notice from.

Comment 2

[Andrew Swan [:aswan]]

Using the topmost window doesn't sound like a good solution. It looks like ExtensionSearchHandler.jsm is the current bridge between the location bar and extensions and it just has the minimum amount of stuff needed, I would say we should add the browser or window to the state it maintains for an input session. However, the location bar is in the middle of a major overhaul, we should definitely check in with the search folks before modifying any of this code. Mike, what say you?

Comment 3

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1516706 extension omnibox incognito/PB support

Comment 4

[Mike de Boer [:mikedeboer]]

Well, I say: use the topmost window if there's no other solution possible. If it's possible, I'd certainly go for passing the addressbar or its ownerGlobal around in the state.

We're indeed working on a rewrite of the addressbar results popup, but the input is staying as it currently is.

Comment 5

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc699e7ded5f8a22d31e545976de5e0b5672f9f2

Comment 6

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=566a42bd0bf1a473e050ea6edf6f141c72a01b82

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2da023bae994
extension omnibox incognito/PB support r=mak

Comment 8

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/2da023bae994

Comment 9

[CosminB]

Attachment: Bug1516706.gif

This issue is verified as fixed on Firefox 67.0a1(20190219213951) under Win 7 64-bit and Mac OS X 10.14.1.

Please see the attached video.