1516805 - Pointer Events in RDM with touch enabled still have pointerType of "mouse"

Status: RESOLVED FIXED

(DevTools :: Responsive Design Mode, defect, P3)

Description

[Patrick H. Lauke]

Attachment: chrome-vs-firefox-emulation-pointerevents.PNG

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.98 Safari/537.36

Steps to reproduce:

1) go to a pointer events test page, like https://patrickhlauke.github.io/touch/tracker/multi-touch-tracker-pointer-hud.html
2) switch to responsive design mode, with touch simulation enabled
3) move the mouse over the page


Actual results:

The mouse cursor position is tracked and reported as a pointer with pointerType of "mouse"


Expected results:

The pointer should have a pointerType of "touch". Compare with Chrome DevTools' device toolbar emulation.

(this is only a small point of the larger shortcomings of RDM in emulating touch, covered already in similar bugs / meta bugs like https://bugzilla.mozilla.org/show_bug.cgi?id=1401304)

Comment 1

[Brad Werth [:bradwerth]]

Yes, this needs to be fixed. Thank you for adding it as a blocker to Bug 1401304.

Comment 2

[Micah [:mtigley] (she/her)]

Stumbled on this issue while working on Bug 1282089. I'll give this one a shot.

Initial thoughts:

• There are methods in the PointerEventHandler class that check if the pointer event should be generated as mouse or touch. Specifically ShouldGeneratePointerEventFromMouse and ShouldGeneratePointerEventFromTouch. This might be a good place to start if we want to try solving this from the platform side of things.

Comment 3

[Micah [:mtigley] (she/her)]

Attachment: Bug 1516805 - Don't dispatch pointer events from a mouse event when simulating touch devices in RDM.

Comment 4

[Micah [:mtigley] (she/her)]

Attachment: Bug 1516805 - Add test that ensures mouse pointer events are not dispatched when touch is enabled.

Depends on D76764

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c070a63a1c8
Don't dispatch pointer events from a mouse event when simulating touch devices in RDM. r=bradwerth,masayuki
https://hg.mozilla.org/integration/autoland/rev/175a146659e0
Add test that ensures mouse pointer events are not dispatched when touch is enabled. r=bradwerth

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/8c070a63a1c8
https://hg.mozilla.org/mozilla-central/rev/175a146659e0