Closed Bug 1516862 Opened 7 years ago Closed 7 years ago

Intermittent toolkit/components/extensions/test/mochitest/test_ext_webrequest_basic.html | expected error message received in onErrorOccurred - Expected: NS_ERROR_UNKNOWN_HOST, Actual: NS_ERROR_NET_ON_RESOLVED

Categories

(WebExtensions :: General, defect, P5)

defect

Tracking

(firefox-esr60 fixed, firefox65 wontfix, firefox66 wontfix, firefox67 fixed)

RESOLVED FIXED
mozilla67
Tracking Status
firefox-esr60 --- fixed
firefox65 --- wontfix
firefox66 --- wontfix
firefox67 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: rpl)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Filed by: csabou [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=219287649&repo=mozilla-central https://queue.taskcluster.net/v1/task/FEIZ6QmcRaSMNjgaACoK-A/runs/0/artifacts/public/logs/live_backing.log 02:41:55 INFO - TEST-PASS | toolkit/components/extensions/test/mochitest/test_ext_webrequest_basic.html | correct requestId - Expected: 352, Actual: 352 02:41:55 INFO - TEST-PASS | toolkit/components/extensions/test/mochitest/test_ext_webrequest_basic.html | correct tabId - Expected: 1, Actual: 1 02:41:55 INFO - Buffered messages finished 02:41:55 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_ext_webrequest_basic.html | expected error message received in onErrorOccurred - Expected: NS_ERROR_UNKNOWN_HOST, Actual: NS_ERROR_NET_ON_RESOLVED 02:41:55 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:275:7 02:41:55 INFO - testHandler@SimpleTest/ExtensionTestUtils.js:59:7 02:41:55 INFO - testResult@SimpleTest/ExtensionTestUtils.js:73:7 02:41:55 INFO - Async*ExtensionTestUtils.loadExtension@SimpleTest/ExtensionTestUtils.js:105:19 02:41:55 INFO - makeExtension@toolkit/components/extensions/test/mochitest/head_webrequest.js:314:10 02:41:55 INFO - setup@toolkit/components/extensions/test/mochitest/test_ext_webrequest_basic.html:46:15 02:41:55 INFO - async*nextTick/<@SimpleTest/AddTask.js:70:34 02:41:55 INFO - async*nextTick@SimpleTest/AddTask.js:44:10 02:41:55 INFO - setTimeout handler*SimpleTest_setTimeoutShim@SimpleTest/SimpleTest.js:684:12 02:41:55 INFO - nextTick@SimpleTest/AddTask.js:40:11 02:41:55 INFO - setTimeout handler*SimpleTest_setTimeoutShim@SimpleTest/SimpleTest.js:684:12 02:41:55 INFO - add_task@SimpleTest/AddTask.js:30:7 02:41:55 INFO - @toolkit/components/extensions/test/mochitest/test_ext_webrequest_basic.html:32:1 02:41:55 INFO - onErrorOccurred 352 https://nonresolvablehostname.invalid/badrobot 02:41:55 INFO - Not taking screenshot here: see the one that was previously logged 02:41:55 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_ext_webrequest_basic.html | received onErrorOccurred 02:41:55 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:275:7 02:41:55 INFO - testHandler@SimpleTest/ExtensionTestUtils.js:63:7 02:41:55 INFO - testResult@SimpleTest/ExtensionTestUtils.js:73:7 02:41:55 INFO - Async*ExtensionTestUtils.loadExtension@SimpleTest/ExtensionTestUtils.js:105:19 02:41:55 INFO - makeExtension@toolkit/components/extensions/test/mochitest/head_webrequest.js:314:10 02:41:55 INFO - setup@toolkit/components/extensions/test/mochitest/test_ext_webrequest_basic.html:46:15 02:41:55 INFO - async*nextTick/<@SimpleTest/AddTask.js:70:34 02:41:55 INFO - async*nextTick@SimpleTest/AddTask.js:44:10 02:41:55 INFO - setTimeout handler*SimpleTest_setTimeoutShim@SimpleTest/SimpleTest.js:684:12 02:41:55 INFO - nextTick@SimpleTest/AddTask.js:40:11 02:41:55 INFO - setTimeout handler*SimpleTest_setTimeoutShim@SimpleTest/SimpleTest.js:684:12 02:41:55 INFO - add_task@SimpleTest/AddTask.js:30:7 02:41:55 INFO - @toolkit/components/extensions/test/mochitest/test_ext_webrequest_basic.html:32:1
Summary: Intermittent [TV] toolkit/components/extensions/test/mochitest/test_ext_webrequest_basic.html | expected error message received in onErrorOccurred - Expected: NS_ERROR_UNKNOWN_HOST, Actual: NS_ERROR_NET_ON_RESOLVED → Intermittent toolkit/components/extensions/test/mochitest/test_ext_webrequest_basic.html | expected error message received in onErrorOccurred - Expected: NS_ERROR_UNKNOWN_HOST, Actual: NS_ERROR_NET_ON_RESOLVED

When the dns resolution for an url's hostname fails, the webRequest API seems to be
receiving (from time to time but more often on macos and windows) more then one call
to the HttpObserverManager.observeActivity method for the activityType

nsISocketTransport.STATUS_RESOLVING and nsISocketTransport.STATUS_RESOLVED

while channel wrapper errorString property is still null.

The observeActvity method goal seems to fire fallback WebRequest errors for error conditions
that are not fired as ChannelWrapper error events, but the "NS_ERROR_UNKNOWN_HOST" error
is also being fired right after the fallback webRequest error event fired as
"NS_ERROR_NET_ON_RESOLVED" (or "NS_ERROR_NET_ON_RESOLVING").

This behavior consistently triggers the two intermittent failures on the test
test_ext_webrequest_basic.html while executing the test_webRequest_frames
task

"expected error message received in onErrorOccurred - Expected: NS_ERROR_UNKNOWN_HOST, Actual: NS_ERROR_NET_ON_RESOLVED"

(when the fallback NS_ERROR_NET_ON_RESOLVED is fired first)

and then

"received onErrorOccurred"

(because the "NS_ERROR_UNKNOWN_HOST" error is also being fired
right after the fallback error message).

Attachment #9049321 - Attachment description: Bug 1516862 - Prevent webRequest multiple error events on dns resolution issues. r?mixedpuppy → Bug 1516862 - Fix test_ext_webRequest intermittency while testing onError events fired on hostname resolving error. r?mixedpuppy!
Attachment #9049321 - Attachment description: Bug 1516862 - Fix test_ext_webRequest intermittency while testing onError events fired on hostname resolving error. r?mixedpuppy! → Bug 1516862 - Fix test_ext_webrequest_basic intermittency while testing onError events fired on hostname resolving error. r?mixedpuppy!
Pushed by luca.greco@alcacoop.it: https://hg.mozilla.org/integration/autoland/rev/32112b7c202e Fix test_ext_webrequest_basic intermittency while testing onError events fired on hostname resolving error. r=mixedpuppy
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Assignee: nobody → lgreco

From my understanding this issue is related to the addon tests. Is there any need of manual QA here? If not can you please mark it as "qe-verify- "

Flags: needinfo?(lgreco)
Flags: needinfo?(lgreco) → qe-verify-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: