Closed Bug 1516877 Opened 5 years ago Closed 5 years ago

Update Readability.js / JSDOMParser.js from git (commit 15d411a8652ca35f553a2465a5bdc994be90a813)

Categories

(Toolkit :: Reader Mode, enhancement, P1)

Product:
Toolkit
Component:
Reader Mode
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla66
Tracking Flags:
Tracking Status
firefox66 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

Details

This is the first sync since bug 1484413 so it may be a bit messy. It also looks like as part of bug 1484413 or some other commit, the disclaimer at the top of the file was lost; we should restore it, and add one to Readability-readerable.js as well.
Git log for relevant changes:

commit 977be42d1fb33781401001318813ab9fe4568647
Author: Gijs Kruitbosch <gijskruitbosch@gmail.com>
Date:   Mon Dec 24 22:31:31 2018 +0000

    Fix link normalization for live HTMLCollections
    
    Newer versions of JSDOM implement getElementsByTagName correctly.
    This means it returns a live node list. When calling
    `Element.replaceChild` for links inside the loop over that
    collection, elements disappear from the list, meaning we miss
    every other item. Without this fix, the `clean-links` testcase
    breaks.

commit e8bb7f722febdc856abf4ac73846afd4f5f7b83d
Author: Gijs Kruitbosch <gijskruitbosch@gmail.com>
Date:   Mon Dec 24 22:28:44 2018 +0000

    Fix whitespace normalization in title metadata
    
    When switching to a newer version of JSDOM, it is more literal
    about listing whitespace as part of textContent, including
    newlines and not normalizing multiple spaces.
    
    It seems prudent to just always normalize whitespace for titles,
    which are guaranteed to be pretty short anyway.

commit 2620542dd1e8380220d82afa97a2c283ae636e40
Author: Gijs Kruitbosch <gijskruitbosch@gmail.com>
Date:   Mon Dec 24 21:03:44 2018 +0000

    Split off isProbablyReaderable implementation

commit 262fffd703edb30a789d8c54a62b0ab776538cb2
Author: Maria Luiza Soares <maria.soares@coolblue.nl>
Date:   Fri Dec 21 16:25:02 2018 +0100

    Retrieve site name on parse, based on meta og:site_name

commit 876c81f710711ba2afb36dd83889d4c5b4fc2743
Author: Gijs <gijskruitbosch@gmail.com>
Date:   Tue Nov 20 09:11:00 2018 +0000

    Update sorting function in Readability.js
    
    Simplify sorting function also considering case where arguments are equal
    
    Co-Authored-By: jemrobinson <james.em.robinson@gmail.com>

commit ee18c21fc2c4b31f9dcf608d33ab12ae1e3032f3
Author: James Robinson <jrobinson@turing.ac.uk>
Date:   Mon Nov 19 16:37:20 2018 +0000

    Switched sort function from boolean to explicit -1 and 1 thus avoiding failures to sort when false is evaluated as 0

commit 44e90de00bc14659f70d9a6c49bf8c071a08b766
Author: Dan Burzo <danburzo@gmail.com>
Date:   Wed Nov 7 15:24:45 2018 +0200

    Elements that have no .style (e.g. mathml) are probably visible; fixes #493


Pull requests:
https://github.com/mozilla/readability/pull/507
https://github.com/mozilla/readability/pull/504
https://github.com/mozilla/readability/pull/497
https://github.com/mozilla/readability/pull/494
Summary: Update Readability.js / JSDOMParser.js from git (commit d8c837012b274e64754e5faf96797ae86b3c5725) → Update Readability.js / JSDOMParser.js from git (commit 15d411a8652ca35f553a2465a5bdc994be90a813)
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/42156d5817a6
update Readability code from upstream (git rev 15d411a8652ca35f553a2465a5bdc994be90a813), rs=already-reviewed
https://hg.mozilla.org/mozilla-central/rev/42156d5817a6
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox66: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.