Open Bug 1516970 Opened 6 years ago Updated 27 days ago

Support generating directory listings for (historical) git revisions at runtime (was: View folder content when browsing revision)

Categories

(Webtools :: Searchfox, enhancement)

Product:
Webtools
Component:
Searchfox
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

People

(Reporter: jdescottes, Unassigned)

References

Details

When browsing a specific revision, the breadcrumbs of folder on top redirect to the "source" revision. STRs: - open https://searchfox.org/mozilla-central/rev/c31e7bd8dc44df0e7ae4fd9f941b07488d77a3ee/devtools/client/themes/common.css#241 - click on any folder in the breadcrumbs ER: see the folder content for the revision I was browsing AR: redirected to https://searchfox.org/mozilla-central/source/... I am not sure if there is any folder view in searchfox today that can point to older revisions?
Currently you cannot view folders in older revisions, but yeah this would be good to have.

In bug 1783761 I refactored directory listings from batch JS that could only handle the head revision to be processed by searchfox-tool/pipeline-server so that the pipeline could handle direct listing information provided by git. This pipeline currently does not understand how to do any git processing, but it would not be a huge undertaking.

Note that I would suggest we explicitly do not attempt to extract a "description" from the historic revisions and either leave that blank or use the current description. The pipeline could actually handle this pretty well and could make it practical to parallelize the lookups, I just wouldn't expect it to be a good performance trade-off.

Depends on: 1783761

Note that since this would want to use the pipeline-server and this is the first pipeline-server functionality that would be non-experimental (alpha/beta gated), that there it appears there is some kind of silly memory leak in the pipeline-server we would likely need to fix. I call it silly because we don't actually intend to have any memory usage that survives an individual HTTP request, but it's quite believable that the fancy logging or some kind of TLS-based caching might be going wrong.

Summary: View folder content when browsing revision → Support generating directory listings for (historical) git revisions at runtime (was: View folder content when browsing revision)
You need to log in before you can comment on or make changes to this bug.